Update WebApkInfo to include badge icon.

Update WebApkInfo to include badge icon.

This CL adds badge icon to WebApkInfo to allow WebAPKs to update badge
icons. Follow-up CLs will propagate this CL to other WebAPK update
components. Eventually shell APK's AndroidManifest.xml would be updated
with the new meta-data introduced by this CL.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1ebMBNhqRew/_6hAQKAfBwAJ

BUG=715158
Review-Url: https://codereview.chromium.org/2912403002
Cr-Commit-Position: refs/heads/master@{#476376}
Committed: https://chromium.googlesource.com/chromium/src/+/d2f0dd39eaacdd2184c8bd53bb9af5b768a56360

[F, 2017-05-31 14:22:33]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 14:22:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[F, 2017-05-31 14:27:51]

Patchset #1 (id:1) has been deleted

[F, 2017-05-31 14:27:58]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 14:28:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[F, 2017-05-31 14:35:18]

Description was changed from

==========
Update WebApkInfo to include badge icon.

BUG=715158
==========

to

==========
Update WebApkInfo to include badge icon.

This CL adds badge icon to WebApkInfo to allow WebAPKs to update badge
icons. Follow-up CLs will propagate this CL to other WebAPK update
components. Eventually shell APK's AndroidManifest.xml would be updated
with the new meta-data introduced by this CL.

BUG=715158
==========

[commit-bot: I haz the power, 2017-05-31 14:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 14:52:50]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[F, 2017-05-31 15:21:46]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[F, 2017-05-31 15:21:53]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-05-31 15:22:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 16:02:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 16:02:08]

Dry run: This issue passed the CQ dry run.

[F, 2017-05-31 18:23:07]

Patchset #1 (id:40001) has been deleted

[F, 2017-05-31 18:23:13]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[F, 2017-05-31 18:23:38]

zpeng@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[F, 2017-05-31 18:23:39]

Hi Peter, PTAL. Thanks!

[commit-bot: I haz the power, 2017-05-31 18:24:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 20:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 20:15:28]

Dry run: This issue passed the CQ dry run.

[pkotwicz, 2017-05-31 22:14:32]

LGTM

[F, 2017-05-31 22:15:23]

zpeng@chromium.org changed reviewers:
+ yfriedman@chromium.org

[F, 2017-05-31 22:15:24]

Thanks Peter!

Hi Yaron, PTAL. Thanks!

[Yaron, 2017-06-01 14:17:53]

can you link to the doc that details the feature more broadly?

https://codereview.chromium.org/2912403002/diff/60001/chrome/android/junit/sr...
File
chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
(right):

https://codereview.chromium.org/2912403002/diff/60001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java:250:
manifestData.badgeIcon = createBitmap(Color.BLUE);
given that this is almost never used currently would prefer it to remain null
rather than allocating a bitmap

https://codereview.chromium.org/2912403002/diff/60001/chrome/android/webapk/l...
File
chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java
(right):

https://codereview.chromium.org/2912403002/diff/60001/chrome/android/webapk/l...
chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java:29:
public static final String BADGE_ICON_ID =
"org.chromium.webapk.shell_apk.badgeIconId";
These should be kept in sync with the AndroidManifest.xml metadata for the shell
apk but it's not been added there yet.

[F, 2017-06-01 14:41:03]

Description was changed from

==========
Update WebApkInfo to include badge icon.

This CL adds badge icon to WebApkInfo to allow WebAPKs to update badge
icons. Follow-up CLs will propagate this CL to other WebAPK update
components. Eventually shell APK's AndroidManifest.xml would be updated
with the new meta-data introduced by this CL.

BUG=715158
==========

to

==========
Update WebApkInfo to include badge icon.

This CL adds badge icon to WebApkInfo to allow WebAPKs to update badge
icons. Follow-up CLs will propagate this CL to other WebAPK update
components. Eventually shell APK's AndroidManifest.xml would be updated
with the new meta-data introduced by this CL.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1ebMBNhqRew/_6hAQKAf...

BUG=715158
==========

[F, 2017-06-01 15:00:28]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 15:00:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 15:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 15:39:28]

Dry run: This issue passed the CQ dry run.

[F, 2017-06-01 15:43:19]

Thanks Yaron! PTAL

I've included the link to the Intent of Implement and Ship in the CL
description.

https://codereview.chromium.org/2912403002/diff/60001/chrome/android/junit/sr...
File
chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
(right):

https://codereview.chromium.org/2912403002/diff/60001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java:250:
manifestData.badgeIcon = createBitmap(Color.BLUE);
On 2017/06/01 14:17:53, Yaron wrote:
> given that this is almost never used currently would prefer it to remain null
> rather than allocating a bitmap

Done.

https://codereview.chromium.org/2912403002/diff/60001/chrome/android/webapk/l...
File
chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java
(right):

https://codereview.chromium.org/2912403002/diff/60001/chrome/android/webapk/l...
chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java:29:
public static final String BADGE_ICON_ID =
"org.chromium.webapk.shell_apk.badgeIconId";
On 2017/06/01 14:17:53, Yaron wrote:
> These should be kept in sync with the AndroidManifest.xml metadata for the
shell
> apk but it's not been added there yet. 

To modify AndroidManifest.xml, shell apk version needs to be updated, which I
think should be done in the last CL for this task. I've removed the value and
added a TODO here. WDUT?

[Yaron, 2017-06-01 16:43:11]

lgtm

https://codereview.chromium.org/2912403002/diff/60001/chrome/android/webapk/l...
File
chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java
(right):

https://codereview.chromium.org/2912403002/diff/60001/chrome/android/webapk/l...
chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java:29:
public static final String BADGE_ICON_ID =
"org.chromium.webapk.shell_apk.badgeIconId";
On 2017/06/01 15:43:19, F wrote:
> On 2017/06/01 14:17:53, Yaron wrote:
> > These should be kept in sync with the AndroidManifest.xml metadata for the
> shell
> > apk but it's not been added there yet. 
> 
> To modify AndroidManifest.xml, shell apk version needs to be updated, which I
> think should be done in the last CL for this task. I've removed the value and
> added a TODO here. WDUT?

better, thanks!

https://codereview.chromium.org/2912403002/diff/80001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
(right):

https://codereview.chromium.org/2912403002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java:200:
* Returns the badge icon in Bitmap form.  Caches the result for future
retrievals.
Err, the second sentence isn't true (and isn't necessary)

[F, 2017-06-01 17:55:39]

Thanks Peter and Yaron!

Submitting soon

https://codereview.chromium.org/2912403002/diff/80001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
(right):

https://codereview.chromium.org/2912403002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java:200:
* Returns the badge icon in Bitmap form.  Caches the result for future
retrievals.
On 2017/06/01 16:43:10, Yaron wrote:
> Err, the second sentence isn't true (and isn't necessary)

Done. My bad, I copied it from WebappInfo

[F, 2017-06-01 17:55:46]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 17:56:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 18:43:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 18:43:18]

Dry run: This issue passed the CQ dry run.

[F, 2017-06-01 18:54:34]

The CQ bit was checked by zpeng@chromium.org

[F, 2017-06-01 18:54:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org, yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/2912403002/#ps100001
(title: "addressing comments")

[commit-bot: I haz the power, 2017-06-01 18:55:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 19:01:59]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496343274765220,
"parent_rev": "fa6afade49688205eb70ba3329a23c91080cf53a", "commit_rev":
"d2f0dd39eaacdd2184c8bd53bb9af5b768a56360"}

[commit-bot: I haz the power, 2017-06-01 19:02:07]

Description was changed from

==========
Update WebApkInfo to include badge icon.

This CL adds badge icon to WebApkInfo to allow WebAPKs to update badge
icons. Follow-up CLs will propagate this CL to other WebAPK update
components. Eventually shell APK's AndroidManifest.xml would be updated
with the new meta-data introduced by this CL.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1ebMBNhqRew/_6hAQKAf...

BUG=715158
==========

to

==========
Update WebApkInfo to include badge icon.

This CL adds badge icon to WebApkInfo to allow WebAPKs to update badge
icons. Follow-up CLs will propagate this CL to other WebAPK update
components. Eventually shell APK's AndroidManifest.xml would be updated
with the new meta-data introduced by this CL.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1ebMBNhqRew/_6hAQKAf...

BUG=715158

Review-Url: https://codereview.chromium.org/2912403002
Cr-Commit-Position: refs/heads/master@{#476376}
Committed:
https://chromium.googlesource.com/chromium/src/+/d2f0dd39eaacdd2184c8bd53bb9a...
==========

[commit-bot: I haz the power, 2017-06-01 19:02:08]

Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d2f0dd39eaacdd2184c8bd53bb9a...