chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java - Issue 2912403002: Update WebApkInfo to include badge icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

Issue 2912403002: Update WebApkInfo to include badge icon. (Closed)

Patch Set: addressing comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java ('k') | chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

index b619e3bf7a429bcd8f6f1184ef7fe65295e1b195..6b36fd83fce5d8b78f65321468e78618e4baef90 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

@@ -184,6 +184,7 @@ public class WebApkUpdateManagerTest {

public Map<String, String> iconUrlToMurmur2HashMap;

public String bestIconUrl;

public Bitmap bestIcon;

+ public Bitmap badgeIcon;

public int displayMode;

public int orientation;

public long themeColor;

@@ -246,6 +247,7 @@ public class WebApkUpdateManagerTest {

manifestData.bestIconUrl = ICON_URL;

manifestData.bestIcon = createBitmap(Color.GREEN);

+ manifestData.badgeIcon = null;

manifestData.displayMode = DISPLAY_MODE;

manifestData.orientation = ORIENTATION;

manifestData.themeColor = THEME_COLOR;

@@ -259,10 +261,10 @@ public class WebApkUpdateManagerTest {

final String kPackageName = "org.random.webapk";

return WebApkInfo.create(getWebApkId(kPackageName), "", false /* forceNavigation */,

manifestData.scopeUrl, new WebApkInfo.Icon(manifestData.bestIcon),

- manifestData.name, manifestData.shortName, manifestData.displayMode,

- manifestData.orientation, -1, manifestData.themeColor, manifestData.backgroundColor,

- kPackageName, -1, WEB_MANIFEST_URL, manifestData.startUrl,

- manifestData.iconUrlToMurmur2HashMap);

+ new WebApkInfo.Icon(manifestData.badgeIcon), manifestData.name,

+ manifestData.shortName, manifestData.displayMode, manifestData.orientation, -1,

+ manifestData.themeColor, manifestData.backgroundColor, kPackageName, -1,

+ WEB_MANIFEST_URL, manifestData.startUrl, manifestData.iconUrlToMurmur2HashMap);

}

/**