Add support for Element.getAttributeNames()

Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0pPWgyGexg

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
Review-Url: https://codereview.chromium.org/2912383002
Cr-Commit-Position: refs/heads/master@{#478220}
Committed: https://chromium.googlesource.com/chromium/src/+/f08b6088f9c359d3fc6862b26ac136c4dbe10fe6

[Shanmuga Pandi, 2017-05-31 14:20:04]

The CQ bit was checked by shanmuga.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 14:20:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 16:07:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 16:07:43]

Dry run: This issue passed the CQ dry run.

[Shanmuga Pandi, 2017-06-01 04:32:40]

Description was changed from

==========
Add support for Element.getAttributeNames()

Add support for Element.getAttributeNames().
Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

to

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

[Shanmuga Pandi, 2017-06-01 04:34:16]

shanmuga.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com, tkent@chromium.org

[Shanmuga Pandi, 2017-06-01 04:34:17]

PTAL!!

Thanks

[Shanmuga Pandi, 2017-06-01 06:02:47]

Description was changed from

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

to

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Intent to implement thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0pPWgyGexg

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

[Shanmuga Pandi, 2017-06-01 06:03:03]

Description was changed from

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Intent to implement thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0pPWgyGexg

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

to

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Intent to implement thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0pPWgyGexg

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

[fs, 2017-06-01 08:39:25]

https://codereview.chromium.org/2912383002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html
(right):

https://codereview.chromium.org/2912383002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html:2:
<title>Element.getAttributeNames() API</title>
Wouldn't it be better to place this test in external/wpt/dom/nodes/? There seems
to be coverage in wpt/dom/nodes/attributes.html already though. (It also looks
almost equivalent to this one, so this is not needed?)

[Shanmuga Pandi, 2017-06-01 09:14:14]

PTAL

https://codereview.chromium.org/2912383002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html
(right):

https://codereview.chromium.org/2912383002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html:2:
<title>Element.getAttributeNames() API</title>
On 2017/06/01 08:39:25, fs wrote:
> Wouldn't it be better to place this test in external/wpt/dom/nodes/? There
seems
> to be coverage in wpt/dom/nodes/attributes.html already though. (It also looks
> almost equivalent to this one, so this is not needed?)

Yes. You are right. I removed this file. It is not needed.

[fs, 2017-06-01 09:21:33]

lgtm

But add '...and ship' where appropriate in the description. And naturally wait
for two more LGTMs in the I2S thread before landing.

[Shanmuga Pandi, 2017-06-01 09:39:20]

Description was changed from

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Intent to implement thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0pPWgyGexg

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

to

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0pPWgyGexg

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

[Shanmuga Pandi, 2017-06-01 09:40:02]

Description was changed from

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0pPWgyGexg

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

to

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0pPWgyGexg

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

[tkent, 2017-06-01 23:48:10]

Please do not land this until the intent is approved.

https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.cpp:2827: Vector<AtomicString>
Element::getAttributeNames() const {
nit: I'd like to move this next to attributesForBindings().

https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.h (right):

https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.h:202: Vector<AtomicString>
getAttributeNames() const;
nit: I'd like to move this next to |attributesForBindings()| to synchronize with
the IDL.

[tkent, 2017-06-02 00:03:57]

On 2017/06/01 at 23:48:10, tkent wrote:
> Please do not land this until the intent is approved.

Oh, it was approved.  lgtm, and please go ahead landing.

[Shanmuga Pandi, 2017-06-02 05:21:51]

https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.cpp:2827: Vector<AtomicString>
Element::getAttributeNames() const {
On 2017/06/01 23:48:10, tkent wrote:
> nit: I'd like to move this next to attributesForBindings().

Done.

https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.h (right):

https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.h:202: Vector<AtomicString>
getAttributeNames() const;
On 2017/06/01 23:48:10, tkent wrote:
> nit: I'd like to move this next to |attributesForBindings()| to synchronize
with
> the IDL.

Done.

[Shanmuga Pandi, 2017-06-02 05:22:00]

The CQ bit was checked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2017-06-02 05:22:01]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
fs@opera.com
Link to the patchset: https://codereview.chromium.org/2912383002/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2017-06-02 05:22:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 05:24:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 05:24:03]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Shanmuga Pandi, 2017-06-05 05:21:59]

The CQ bit was checked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2017-06-05 05:21:59]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
fs@opera.com
Link to the patchset: https://codereview.chromium.org/2912383002/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2017-06-05 05:22:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shanmuga Pandi, 2017-06-05 05:28:09]

shanmuga.m@samsung.com changed reviewers:
+ timvolodine@chromium.org

[Shanmuga Pandi, 2017-06-05 05:28:09]

timvolodine@chromium.org: Please review changes in 

android_webview/tools/

[commit-bot: I haz the power, 2017-06-05 05:31:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 05:31:07]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shanmuga Pandi, 2017-06-07 04:50:26]

@timvolodine : please review android_webview/ changes.
Thank you

[timvolodine, 2017-06-08 20:31:22]

On 2017/06/07 04:50:26, Shanmuga Pandi wrote:
> @timvolodine : please review android_webview/ changes.
> Thank you

android_webview/.. -- lgtm

[Shanmuga Pandi, 2017-06-09 05:09:04]

The CQ bit was checked by shanmuga.m@samsung.com

[commit-bot: I haz the power, 2017-06-09 05:09:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 07:13:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496984944641180,
"parent_rev": "f054cd0787297aa08098edb9dcc2cdde7cc03fc4", "commit_rev":
"f08b6088f9c359d3fc6862b26ac136c4dbe10fe6"}

[commit-bot: I haz the power, 2017-06-09 07:14:02]

Description was changed from

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0pPWgyGexg

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433
==========

to

==========
Add support for Element.getAttributeNames()

Spec:
https://dom.spec.whatwg.org/#dom-element-getattributenames

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0pPWgyGexg

Webkit patch:
https://trac.webkit.org/changeset/203852/webkit

BUG=727433

Review-Url: https://codereview.chromium.org/2912383002
Cr-Commit-Position: refs/heads/master@{#478220}
Committed:
https://chromium.googlesource.com/chromium/src/+/f08b6088f9c359d3fc6862b26ac1...
==========

[commit-bot: I haz the power, 2017-06-09 07:14:06]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f08b6088f9c359d3fc6862b26ac1...