Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2912383002: Add support for Element.getAttributeNames() (Closed)

Created:
3 years, 6 months ago by Shanmuga Pandi
Modified:
3 years, 6 months ago
Reviewers:
tkent, fs, foolip, timvolodine
CC:
android-webview-reviews_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, mac-reviews_chromium.org, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed redundant file #

Total comments: 4

Patch Set 3 : nits #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1576 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt View 1 2 3 1 chunk +0 lines, -1574 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/attributes-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 36 (20 generated)
Shanmuga Pandi
PTAL!! Thanks
3 years, 6 months ago (2017-06-01 04:34:17 UTC) #7
fs
https://codereview.chromium.org/2912383002/diff/1/third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html File third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html (right): https://codereview.chromium.org/2912383002/diff/1/third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html#newcode2 third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html:2: <title>Element.getAttributeNames() API</title> Wouldn't it be better to place this ...
3 years, 6 months ago (2017-06-01 08:39:25 UTC) #10
Shanmuga Pandi
PTAL https://codereview.chromium.org/2912383002/diff/1/third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html File third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html (right): https://codereview.chromium.org/2912383002/diff/1/third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html#newcode2 third_party/WebKit/LayoutTests/fast/dom/Element/getAttributeNames.html:2: <title>Element.getAttributeNames() API</title> On 2017/06/01 08:39:25, fs wrote: > ...
3 years, 6 months ago (2017-06-01 09:14:14 UTC) #11
fs
lgtm But add '...and ship' where appropriate in the description. And naturally wait for two ...
3 years, 6 months ago (2017-06-01 09:21:33 UTC) #12
tkent
Please do not land this until the intent is approved. https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Source/core/dom/Element.cpp File third_party/WebKit/Source/core/dom/Element.cpp (right): https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Source/core/dom/Element.cpp#newcode2827 ...
3 years, 6 months ago (2017-06-01 23:48:10 UTC) #15
tkent
On 2017/06/01 at 23:48:10, tkent wrote: > Please do not land this until the intent ...
3 years, 6 months ago (2017-06-02 00:03:57 UTC) #16
Shanmuga Pandi
https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Source/core/dom/Element.cpp File third_party/WebKit/Source/core/dom/Element.cpp (right): https://codereview.chromium.org/2912383002/diff/20001/third_party/WebKit/Source/core/dom/Element.cpp#newcode2827 third_party/WebKit/Source/core/dom/Element.cpp:2827: Vector<AtomicString> Element::getAttributeNames() const { On 2017/06/01 23:48:10, tkent wrote: ...
3 years, 6 months ago (2017-06-02 05:21:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912383002/40001
3 years, 6 months ago (2017-06-02 05:22:14 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/224162) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-02 05:24:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912383002/60001
3 years, 6 months ago (2017-06-05 05:22:46 UTC) #25
Shanmuga Pandi
timvolodine@chromium.org: Please review changes in android_webview/tools/
3 years, 6 months ago (2017-06-05 05:28:09 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/455369)
3 years, 6 months ago (2017-06-05 05:31:07 UTC) #29
Shanmuga Pandi
@timvolodine : please review android_webview/ changes. Thank you
3 years, 6 months ago (2017-06-07 04:50:26 UTC) #30
timvolodine
On 2017/06/07 04:50:26, Shanmuga Pandi wrote: > @timvolodine : please review android_webview/ changes. > Thank ...
3 years, 6 months ago (2017-06-08 20:31:22 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912383002/60001
3 years, 6 months ago (2017-06-09 05:09:21 UTC) #33
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 07:14:06 UTC) #36
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f08b6088f9c359d3fc6862b26ac1...

Powered by Google App Engine
This is Rietveld 408576698