Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2912303002: Limit visibility {Left,Right}BoundaryOfLine() to SelectionModifier only (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit visibility {Left,Right}BoundaryOfLine() to SelectionModifier only This patch moves |{Left,Right}BoundaryOfLine()| to "SelectionModifier.cpp" as file local functions since these functions are used in |SelectionModifier| class only, for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2912303002 Cr-Commit-Position: refs/heads/master@{#475863} Committed: https://chromium.googlesource.com/chromium/src/+/1712085e2cbb5ce8e817a94dd59c90f31eaf9f27

Patch Set 1 : 2017-05-31T17:14:49 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionModifier.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-05-31 09:12:08 UTC) #6
yoichio
lgtm
3 years, 6 months ago (2017-05-31 09:31:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912303002/1
3 years, 6 months ago (2017-05-31 09:32:23 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 10:06:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1712085e2cbb5ce8e817a94dd59c...

Powered by Google App Engine
This is Rietveld 408576698