Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleUnits.h

Issue 2912303002: Limit visibility {Left,Right}BoundaryOfLine() to SelectionModifier only (Closed)
Patch Set: 2017-05-31T17:14:49 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 CORE_EXPORT VisiblePositionInFlatTree 241 CORE_EXPORT VisiblePositionInFlatTree
242 LogicalStartOfLine(const VisiblePositionInFlatTree&); 242 LogicalStartOfLine(const VisiblePositionInFlatTree&);
243 // TODO(yosin) Return values of |VisiblePosition| version of 243 // TODO(yosin) Return values of |VisiblePosition| version of
244 // |logicalEndOfLine()| with shadow tree isn't defined well. We should not use 244 // |logicalEndOfLine()| with shadow tree isn't defined well. We should not use
245 // it for shadow tree. 245 // it for shadow tree.
246 CORE_EXPORT VisiblePosition LogicalEndOfLine(const VisiblePosition&); 246 CORE_EXPORT VisiblePosition LogicalEndOfLine(const VisiblePosition&);
247 CORE_EXPORT VisiblePositionInFlatTree 247 CORE_EXPORT VisiblePositionInFlatTree
248 LogicalEndOfLine(const VisiblePositionInFlatTree&); 248 LogicalEndOfLine(const VisiblePositionInFlatTree&);
249 CORE_EXPORT bool IsLogicalEndOfLine(const VisiblePosition&); 249 CORE_EXPORT bool IsLogicalEndOfLine(const VisiblePosition&);
250 CORE_EXPORT bool IsLogicalEndOfLine(const VisiblePositionInFlatTree&); 250 CORE_EXPORT bool IsLogicalEndOfLine(const VisiblePositionInFlatTree&);
251 VisiblePosition LeftBoundaryOfLine(const VisiblePosition&, TextDirection);
252 VisiblePosition RightBoundaryOfLine(const VisiblePosition&, TextDirection);
253 251
254 // paragraphs (perhaps a misnomer, can be divided by line break elements) 252 // paragraphs (perhaps a misnomer, can be divided by line break elements)
255 // TODO(yosin) Since return value of |startOfParagraph()| with |VisiblePosition| 253 // TODO(yosin) Since return value of |startOfParagraph()| with |VisiblePosition|
256 // isn't defined well on flat tree, we should not use it for a position in 254 // isn't defined well on flat tree, we should not use it for a position in
257 // flat tree. 255 // flat tree.
258 CORE_EXPORT VisiblePosition 256 CORE_EXPORT VisiblePosition
259 StartOfParagraph(const VisiblePosition&, 257 StartOfParagraph(const VisiblePosition&,
260 EditingBoundaryCrossingRule = kCannotCrossEditingBoundary); 258 EditingBoundaryCrossingRule = kCannotCrossEditingBoundary);
261 CORE_EXPORT VisiblePositionInFlatTree 259 CORE_EXPORT VisiblePositionInFlatTree
262 StartOfParagraph(const VisiblePositionInFlatTree&, 260 StartOfParagraph(const VisiblePositionInFlatTree&,
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 const VisiblePosition&, 356 const VisiblePosition&,
359 EditableType); 357 EditableType);
360 358
361 Position PreviousRootInlineBoxCandidatePosition(Node*, 359 Position PreviousRootInlineBoxCandidatePosition(Node*,
362 const VisiblePosition&, 360 const VisiblePosition&,
363 EditableType); 361 EditableType);
364 362
365 } // namespace blink 363 } // namespace blink
366 364
367 #endif // VisibleUnits_h 365 #endif // VisibleUnits_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/SelectionModifier.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698