[CRD iOS] Consistent host list order and showing last online time

[CRD iOS] Consistent host list order and showing last online time

This CL:
* Gives consistent sorting order to the host list, similar to how the
  HostListManager is doing in Android.
* Shows the localized last online time on the host list.
* Fixes some issues when parsing the HostInfo. HostOs should
  have lower case s and it doesn't need to fail if the JSON is
  missing these fields.

BUG=728280
Review-Url: https://codereview.chromium.org/2912293003
Cr-Commit-Position: refs/heads/master@{#476012}
Committed: https://chromium.googlesource.com/chromium/src/+/5d138159d521118ad2a61d5ae34767e7c05adb6d

[Yuwei, 2017-05-31 18:44:36]

Description was changed from

==========
[CRD iOS] Consistent host list order and showing last online time

This CL:
* Gives consistent sorting order to the host list, similar to how the
  HostListManager is doing in Android.
* Show the localized last online time on the host list.

BUG=728280
==========

to

==========
[CRD iOS] Consistent host list order and showing last online time

This CL:
* Gives consistent sorting order to the host list, similar to how the
  HostListManager is doing in Android.
* Shows the localized last online time on the host list.
* Fixes some issues when parsing the HostInfo. HostOs should
  have lower case s and it doesn't need to fail if the JSON is
  missing these fields.

BUG=728280
==========

[Yuwei, 2017-05-31 18:49:03]

yuweih@chromium.org changed reviewers:
+ nicholss@chromium.org

[Yuwei, 2017-05-31 18:49:04]

PTAL

I guess I'll also need to fix/add some unit tests but you can still take a look
first.

Thanks!

https://codereview.chromium.org/2912293003/diff/1/remoting/ios/domain/host_in...
File remoting/ios/domain/host_info.mm (right):

https://codereview.chromium.org/2912293003/diff/1/remoting/ios/domain/host_in...
remoting/ios/domain/host_info.mm:59: //    NSString* ISO8601DateString = [svr
objectForKey:@"updatedTime"];
It looks like parseListFromJSON is never used?

[Yuwei, 2017-05-31 18:53:36]

On 2017/05/31 18:49:04, Yuwei wrote:
> PTAL
> 
> I guess I'll also need to fix/add some unit tests but you can still take a
look
> first.
> 
> Thanks!
> 
>
https://codereview.chromium.org/2912293003/diff/1/remoting/ios/domain/host_in...
> File remoting/ios/domain/host_info.mm (right):
> 
>
https://codereview.chromium.org/2912293003/diff/1/remoting/ios/domain/host_in...
> remoting/ios/domain/host_info.mm:59: //    NSString* ISO8601DateString = [svr
> objectForKey:@"updatedTime"];
> It looks like parseListFromJSON is never used?

Okay... It doesn't look like HostListFetcher has any unittest. Anyway _(:_」∠)_

[nicholss, 2017-05-31 19:32:37]

lgtm thanks!

https://codereview.chromium.org/2912293003/diff/20001/remoting/ios/domain/hos...
File remoting/ios/domain/host_info.mm (right):

https://codereview.chromium.org/2912293003/diff/20001/remoting/ios/domain/hos...
remoting/ios/domain/host_info.mm:59: //    NSString* ISO8601DateString = [svr
objectForKey:@"updatedTime"];
Do we need this anymore then? Can we delete?

[Yuwei, 2017-05-31 19:55:47]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 19:56:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuwei, 2017-05-31 20:36:40]

Thanks!

https://codereview.chromium.org/2912293003/diff/20001/remoting/ios/domain/hos...
File remoting/ios/domain/host_info.mm (right):

https://codereview.chromium.org/2912293003/diff/20001/remoting/ios/domain/hos...
remoting/ios/domain/host_info.mm:59: //    NSString* ISO8601DateString = [svr
objectForKey:@"updatedTime"];
On 2017/05/31 19:32:37, nicholss wrote:
> Do we need this anymore then? Can we delete?

I don't think it's needed any more. I'll delete it in a separate CL.

[Yuwei, 2017-05-31 20:36:44]

The CQ bit was unchecked by yuweih@chromium.org

[Yuwei, 2017-05-31 20:36:49]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2017-05-31 20:37:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 20:48:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496263009469450,
"parent_rev": "ceb85f8308e79cdc433d902aa299b316afcf82da", "commit_rev":
"5d138159d521118ad2a61d5ae34767e7c05adb6d"}

[commit-bot: I haz the power, 2017-05-31 20:48:11]

Description was changed from

==========
[CRD iOS] Consistent host list order and showing last online time

This CL:
* Gives consistent sorting order to the host list, similar to how the
  HostListManager is doing in Android.
* Shows the localized last online time on the host list.
* Fixes some issues when parsing the HostInfo. HostOs should
  have lower case s and it doesn't need to fail if the JSON is
  missing these fields.

BUG=728280
==========

to

==========
[CRD iOS] Consistent host list order and showing last online time

This CL:
* Gives consistent sorting order to the host list, similar to how the
  HostListManager is doing in Android.
* Shows the localized last online time on the host list.
* Fixes some issues when parsing the HostInfo. HostOs should
  have lower case s and it doesn't need to fail if the JSON is
  missing these fields.

BUG=728280

Review-Url: https://codereview.chromium.org/2912293003
Cr-Commit-Position: refs/heads/master@{#476012}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d138159d521118ad2a61d5ae347...
==========

[commit-bot: I haz the power, 2017-05-31 20:48:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5d138159d521118ad2a61d5ae347...