[CRD iOS] Consistent host list order and showing last online time

remoting/ios/facade/host_list_fetcher.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/ios/facade/host_list_fetcher.h"
 
+#include <algorithm>
 #include <thread>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/json/json_reader.h"
 #include "base/logging.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/values.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/url_fetcher.h"
 #include "remoting/base/url_request_context_getter.h"
 
 namespace remoting {
 
+namespace {
+
+// Returns true if |h1| should sort before |h2|.
+bool compareHost(const HostInfo& h1, const HostInfo& h2) {
+  // Online hosts always sort before offline hosts.
+  if (h1.status != h2.status) {
+    return h1.status == HostStatus::kHostStatusOnline;
+  }
+
+  // Sort by host name.
+  int name_compare = h1.host_name.compare(h2.host_name);
+  if (name_compare != 0) {
+    return name_compare < 0;
+  }
+
+  // Sort by last update time if names are identical.
+  return h1.updated_time < h2.updated_time;
+}
+
+}  // namespace
+
 HostListFetcher::HostListFetcher(
     const scoped_refptr<net::URLRequestContextGetter>&
         url_request_context_getter)
     : url_request_context_getter_(url_request_context_getter) {}
 
 HostListFetcher::~HostListFetcher() {}
 
 // TODO(nicholss): This was written assuming only one request at a time. Fix
 // that. For the moment it will work to make progress in the app.
 void HostListFetcher::RetrieveHostlist(const std::string& access_token,
@@ skipping 67 matching lines @@
   return true;
 }
 
 void HostListFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
   DCHECK(source);
 
   std::vector<HostInfo> hostlist;
   if (!ProcessResponse(&hostlist)) {
     hostlist.clear();
   }
+  std::sort(hostlist.begin(), hostlist.end(), &compareHost);
   base::ResetAndReturn(&hostlist_callback_).Run(hostlist);
 }
 
 }  // namespace remoting