Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 2912123002: [Merge to M60] X11: Fix use-of-uninitialized-variable (Closed)

Created:
3 years, 6 months ago by Tom Anderson
Modified:
3 years, 6 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Merge to M60] X11: Fix use-of-uninitialized-variable > Some failure paths in XGetVisualInfo don't set |nitems_return| to 0, > and instead just return nullptr directly. This CL initializes that > variable to 0 manually to handle those cases. > > BUG=725884 > R=derat@chromium.org > > Review-Url: https://codereview.chromium.org/2910753002 > Cr-Commit-Position: refs/heads/master@{#475159} BUG=725884 TBR=derat@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2912123002 Cr-Commit-Position: refs/branch-heads/3112@{#34} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/00b8c5e102551cff803b67ca26678c0f1b0348e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/base/x/x11_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912123002/1
3 years, 6 months ago (2017-05-30 18:20:09 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 18:20:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00b8c5e102551cff803b67ca2667...

Powered by Google App Engine
This is Rietveld 408576698