Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2910753002: X11: Fix use-of-uninitialized-variable (Closed)

Created:
3 years, 7 months ago by Tom Anderson
Modified:
3 years, 7 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

X11: Fix use-of-uninitialized-variable Some failure paths in XGetVisualInfo don't set |nitems_return| to 0, and instead just return nullptr directly. This CL initializes that variable to 0 manually to handle those cases. BUG=725884 R=derat@chromium.org Review-Url: https://codereview.chromium.org/2910753002 Cr-Commit-Position: refs/heads/master@{#475159} Committed: https://chromium.googlesource.com/chromium/src/+/6a5692489564312b0ef27ad53e81289f8d3092d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/base/x/x11_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Anderson
3 years, 7 months ago (2017-05-26 20:50:58 UTC) #2
Daniel Erat
lgtm
3 years, 7 months ago (2017-05-26 22:07:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910753002/1
3 years, 7 months ago (2017-05-26 22:10:02 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 22:16:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a5692489564312b0ef27ad53e81...

Powered by Google App Engine
This is Rietveld 408576698