Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2911963004: Generate enum/getters/setters/mappings for user-select. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for user-select. Currently, the user-select property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EUserSelect enum and use the generated CSSValueID <-> EUserSelect mappings. Diff of generated files: https://gist.github.com/darrnshn/55f9abda5310dd37a0b60386f23e0e4a/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2911963004 Cr-Commit-Position: refs/heads/master@{#475867} Committed: https://chromium.googlesource.com/chromium/src/+/adccf92c92a9fa6094191e3938b3bd42948751fd

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -52 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueIDMappings.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (19 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-30 23:17:39 UTC) #9
rune
lgtm
3 years, 6 months ago (2017-05-31 09:41:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911963004/40001
3 years, 6 months ago (2017-05-31 10:17:46 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 10:22:56 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/adccf92c92a9fa6094191e3938b3...

Powered by Google App Engine
This is Rietveld 408576698