Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2912923003: Generate enum/getters/setters/mappings for user-modify. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for user-modify. Currently, the user-modify property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EUserModify enum and use the generated CSSValueID <-> EUserModify mappings. Diff of generated files: https://gist.github.com/21e3b6343b06a190a48ab3e22c9e10bc/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2912923003 Cr-Commit-Position: refs/heads/master@{#476141} Committed: https://chromium.googlesource.com/chromium/src/+/b4e5b1d42138414abcef8816f6af08fbebdbccd2

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -50 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-30 23:17:50 UTC) #4
meade_UTC10
lgtm, but please add a diff
3 years, 6 months ago (2017-05-31 06:01:26 UTC) #7
shend
On 2017/05/31 at 06:01:26, meade wrote: > lgtm, but please add a diff done
3 years, 6 months ago (2017-05-31 06:17:33 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 2911963004 Patch 40001). Please resolve the dependency and ...
3 years, 6 months ago (2017-05-31 06:17:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912923003/1
3 years, 6 months ago (2017-05-31 22:40:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912923003/20001
3 years, 6 months ago (2017-06-01 01:45:31 UTC) #21
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 01:51:05 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b4e5b1d42138414abcef8816f6af...

Powered by Google App Engine
This is Rietveld 408576698