Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2911943002: [vr] Add incognito coloring (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[vr] Add incognito coloring This changes the background, grid, and URL bar coloring when in incognito mode. BUG=715664 Review-Url: https://codereview.chromium.org/2902043005 Cr-Original-Commit-Position: refs/heads/master@{#475234} Review-Url: https://codereview.chromium.org/2911943002 . Cr-Commit-Position: refs/branch-heads/3112@{#18} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/2af20849d31b972e9c11253b2a96bed7bb6f45ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -70 lines) Patch
M chrome/browser/android/vr_shell/color_scheme.h View 2 chunks +21 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/color_scheme.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/ui_texture.h View 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/ui_texture.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 11 chunks +38 lines, -34 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc View 8 chunks +43 lines, -18 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/textured_element.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/textured_element.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/ui_element.h View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/ui_element.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_interface.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.h View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.cc View 1 chunk +13 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.h View 5 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 5 chunks +20 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
cjgrant
3 years, 6 months ago (2017-05-29 19:02:40 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2af20849d31b972e9c11253b2a96bed7bb6f45ce.

Powered by Google App Engine
This is Rietveld 408576698