Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2911643004: Ignore calls to SatisfySequence if CanvasSurfaceLayerBridge is gone (Closed)

Created:
3 years, 6 months ago by Saman Sami
Modified:
3 years, 6 months ago
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore calls to SatisfySequence if CanvasSurfaceLayerBridge is gone Since SatisfySequence is post-tasked, under certain race conditions it's possible that CanvasSurfaceLayerBridge is gone when it's called. Simply ignore the call in that case. Note that RequireSequence is not PostTasked so I expect bridge_ to exist. BUG=720188 Review-Url: https://codereview.chromium.org/2911643004 Cr-Commit-Position: refs/heads/master@{#475378} Committed: https://chromium.googlesource.com/chromium/src/+/d5bf6c6f5651782d2fe6db6194d7e9776e2aff35

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 20 (13 generated)
Saman Sami
3 years, 6 months ago (2017-05-26 20:46:51 UTC) #7
Fady Samuel
https://codereview.chromium.org/2911643004/diff/1/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp File third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp (right): https://codereview.chromium.org/2911643004/diff/1/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp#newcode48 third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp:48: bridge_->SatisfyCallback(sequence); maybe do this for require too?
3 years, 6 months ago (2017-05-26 20:47:57 UTC) #9
jbroman
This lgtm, but junov is probably better-acquainted with the expected lifetime of the bridge.
3 years, 6 months ago (2017-05-29 15:36:32 UTC) #13
Justin Novosad
This makes total sense IMHO. lgtm
3 years, 6 months ago (2017-05-29 16:56:26 UTC) #14
Saman Sami
Thanks for the lgtms. https://codereview.chromium.org/2911643004/diff/1/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp File third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp (right): https://codereview.chromium.org/2911643004/diff/1/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp#newcode48 third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp:48: bridge_->SatisfyCallback(sequence); On 2017/05/26 20:47:57, Fady ...
3 years, 6 months ago (2017-05-29 17:48:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911643004/1
3 years, 6 months ago (2017-05-29 17:48:36 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 20:04:08 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5bf6c6f5651782d2fe6db6194d7...

Powered by Google App Engine
This is Rietveld 408576698