Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp

Issue 2911643004: Ignore calls to SatisfySequence if CanvasSurfaceLayerBridge is gone (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/CanvasSurfaceLayerBridge.h" 5 #include "platform/graphics/CanvasSurfaceLayerBridge.h"
6 6
7 #include "cc/layers/layer.h" 7 #include "cc/layers/layer.h"
8 #include "cc/layers/solid_color_layer.h" 8 #include "cc/layers/solid_color_layer.h"
9 #include "cc/layers/surface_layer.h" 9 #include "cc/layers/surface_layer.h"
10 #include "cc/surfaces/sequence_surface_reference_factory.h" 10 #include "cc/surfaces/sequence_surface_reference_factory.h"
(...skipping 26 matching lines...) Expand all
37 ~OffscreenCanvasSurfaceReferenceFactory() override = default; 37 ~OffscreenCanvasSurfaceReferenceFactory() override = default;
38 38
39 // cc::SequenceSurfaceReferenceFactory implementation: 39 // cc::SequenceSurfaceReferenceFactory implementation:
40 void RequireSequence(const cc::SurfaceId& id, 40 void RequireSequence(const cc::SurfaceId& id,
41 const cc::SurfaceSequence& sequence) const override { 41 const cc::SurfaceSequence& sequence) const override {
42 DCHECK(bridge_); 42 DCHECK(bridge_);
43 bridge_->RequireCallback(id, sequence); 43 bridge_->RequireCallback(id, sequence);
44 } 44 }
45 45
46 void SatisfySequence(const cc::SurfaceSequence& sequence) const override { 46 void SatisfySequence(const cc::SurfaceSequence& sequence) const override {
47 DCHECK(bridge_); 47 if (bridge_)
48 bridge_->SatisfyCallback(sequence); 48 bridge_->SatisfyCallback(sequence);
Fady Samuel 2017/05/26 20:47:57 maybe do this for require too?
Saman Sami 2017/05/29 17:48:22 I expect bridge_ to exist in RequireSequence. Sati
49 } 49 }
50 50
51 base::WeakPtr<CanvasSurfaceLayerBridge> bridge_; 51 base::WeakPtr<CanvasSurfaceLayerBridge> bridge_;
52 52
53 DISALLOW_COPY_AND_ASSIGN(OffscreenCanvasSurfaceReferenceFactory); 53 DISALLOW_COPY_AND_ASSIGN(OffscreenCanvasSurfaceReferenceFactory);
54 }; 54 };
55 55
56 } // namespace 56 } // namespace
57 57
58 CanvasSurfaceLayerBridge::CanvasSurfaceLayerBridge( 58 CanvasSurfaceLayerBridge::CanvasSurfaceLayerBridge(
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 service_->Satisfy(sequence); 126 service_->Satisfy(sequence);
127 } 127 }
128 128
129 void CanvasSurfaceLayerBridge::RequireCallback( 129 void CanvasSurfaceLayerBridge::RequireCallback(
130 const cc::SurfaceId& surface_id, 130 const cc::SurfaceId& surface_id,
131 const cc::SurfaceSequence& sequence) { 131 const cc::SurfaceSequence& sequence) {
132 service_->Require(surface_id, sequence); 132 service_->Require(surface_id, sequence);
133 } 133 }
134 134
135 } // namespace blink 135 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698