Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(33)

Issue 2911643003: Reland of Add missing dependencies on exe_and_shlib_deps (Chromium repo) (Closed)

Created:
1 year, 12 months ago by Tom Anderson
Modified:
1 year, 12 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, eme-reviews_chromium.org, jasonroberts+watch_google.com, chromoting-reviews_chromium.org, avayvod+watch_chromium.org, net-reviews_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add missing dependencies on exe_and_shlib_deps (Chromium repo) (patchset #1 id:1 of https://codereview.chromium.org/2912513002/ ) Reason for revert: The failing build [1] failed because of an internal issue (gclient sync failure), not because of the original cl [1] https://build.chromium.org/p/chromium.linux/builders/Deterministic%20Linux/builds/3055 Original issue's description: > Revert of Add missing dependencies on exe_and_shlib_deps (Chromium repo) (patchset #2 id:60001 of https://codereview.chromium.org/2899403004/ ) > > Reason for revert: > BUG=726808 > > Suspecting causing generate_build_files failure (according to FindIt) > > Original issue's description: > > Add missing dependencies on exe_and_shlib_deps (Chromium repo) > > > > BUG=723069 > > R=brettw@chromium.org > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > > > Review-Url: https://codereview.chromium.org/2899403004 > > Cr-Commit-Position: refs/heads/master@{#475059} > > Committed: https://chromium.googlesource.com/chromium/src/+/9e926233bf660c42676d6bd4cb77dade846aca69 > > TBR=brettw@chromium.org,davidben@chromium.org,thomasanderson@google.com,thomasanderson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=723069 > > Review-Url: https://codereview.chromium.org/2912513002 > Cr-Commit-Position: refs/heads/master@{#475077} > Committed: https://chromium.googlesource.com/chromium/src/+/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7 TBR=brettw@chromium.org,davidben@chromium.org,thomasanderson@google.com,nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=726808 Review-Url: https://codereview.chromium.org/2911643003 Cr-Commit-Position: refs/heads/master@{#475086} Committed: https://chromium.googlesource.com/chromium/src/+/b7a527720b277b3ec4af030be6c32e288f0b18c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M components/url_formatter/top_domains/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M headless/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M media/cast/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M media/cdm/ppapi/ppapi_cdm_adapter.gni View 1 chunk +1 line, -0 lines 0 comments Download
M net/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/examples/ppapi_example.gni View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/linux/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/leveldatabase/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Anderson
Created Reland of Add missing dependencies on exe_and_shlib_deps (Chromium repo)
1 year, 12 months ago (2017-05-26 19:25:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911643003/1
1 year, 12 months ago (2017-05-26 19:26:12 UTC) #3
commit-bot: I haz the power
1 year, 12 months ago (2017-05-26 19:27:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7a527720b277b3ec4af030be6c3...

Powered by Google App Engine
This is Rietveld 408576698