Initial translation event proto.

Initial translation event proto.

Design doc:
https://docs.google.com/document/d/1-q-vrxqNZDnwajpOwMWB_Z1YlzQUiApJZmSUzGkojv4/edit#heading=h.3bxjhvo21dyq

Integration Steps:
https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_D8/edit#

BUG=

Review-Url: https://codereview.chromium.org/2911603002
Cr-Commit-Position: refs/heads/master@{#476174}
Committed: https://chromium.googlesource.com/chromium/src/+/eb3d357883dd94b2875bfeeb2e1a5b4ad7ce7b6e

[renjieliu1, 2017-05-26 02:32:49]

The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 02:33:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[renjieliu1, 2017-05-26 03:31:36]

Description was changed from

==========
Initial translation event proto.

Design doc:
https://docs.google.com/document/d/1-q-vrxqNZDnwajpOwMWB_Z1YlzQUiApJZmSUzGkoj...

Integration Steps:
https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_...

BUG=
==========

to

==========
Initial translation event proto.

Design doc:
https://docs.google.com/document/d/1-q-vrxqNZDnwajpOwMWB_Z1YlzQUiApJZmSUzGkoj...

Integration Steps:
https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_...

BUG=
==========

[renjieliu1, 2017-05-26 03:31:36]

renjieliu@chromium.org changed reviewers:
+ amoylan@chromium.org, napper@chromium.org

[renjieliu1, 2017-05-26 03:32:40]

The initial translation event proto as discussed here:
https://docs.google.com/document/d/1-q-vrxqNZDnwajpOwMWB_Z1YlzQUiApJZmSUzGkoj...

[renjieliu1, 2017-05-26 04:33:11]

FYI, the local translate event is defined here:

https://cs.chromium.org/chromium/src/components/metrics/proto/translate_event...

[commit-bot: I haz the power, 2017-05-26 04:43:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 04:43:25]

Dry run: This issue passed the CQ dry run.

[amoylan, 2017-05-26 05:12:42]

lgtm

https://codereview.chromium.org/2911603002/diff/1/components/sync/protocol/us...
File components/sync/protocol/user_event_specifics.proto (right):

https://codereview.chromium.org/2911603002/diff/1/components/sync/protocol/us...
components/sync/protocol/user_event_specifics.proto:44: optional string
from_language_code = 1;
We need a comment on these fields (from_language_code, to_language_code).
Actually I think we need a somewhat detailed comment  here, because I feel like
they can have a different meaning (or no meaning) depending on the value of
Interaction enum.

For example, if interaction == MANUAL, will the from_ and to_ be the previous
auto-chosen values? Or the updated values? Or maybe exactly one of the from_ and
to_ will be set, indicating which one the user did manually enter?

[renjieliu1, 2017-05-29 00:09:50]

Also update the fields (remove always translate and never translate as they're
recorded in user prefers)

https://codereview.chromium.org/2911603002/diff/1/components/sync/protocol/us...
File components/sync/protocol/user_event_specifics.proto (right):

https://codereview.chromium.org/2911603002/diff/1/components/sync/protocol/us...
components/sync/protocol/user_event_specifics.proto:44: optional string
from_language_code = 1;
On 2017/05/26 05:12:42, amoylan wrote:
> We need a comment on these fields (from_language_code, to_language_code).
> Actually I think we need a somewhat detailed comment  here, because I feel
like
> they can have a different meaning (or no meaning) depending on the value of
> Interaction enum.
> 
> For example, if interaction == MANUAL, will the from_ and to_ be the previous
> auto-chosen values? Or the updated values? Or maybe exactly one of the from_
and
> to_ will be set, indicating which one the user did manually enter?

Done.

[napper, 2017-05-29 00:23:49]

https://codereview.chromium.org/2911603002/diff/20001/components/sync/protoco...
File components/sync/protocol/user_event_specifics.proto (right):

https://codereview.chromium.org/2911603002/diff/20001/components/sync/protoco...
components/sync/protocol/user_event_specifics.proto:48: enum Interaction {
You also need:

- never translate language
- never translate site
- always translate language
- translation reverted
- automatic translation

[amoylan, 2017-05-29 00:30:19]

On 2017/05/29 00:23:49, napper wrote:
>
https://codereview.chromium.org/2911603002/diff/20001/components/sync/protoco...
> File components/sync/protocol/user_event_specifics.proto (right):
> 
>
https://codereview.chromium.org/2911603002/diff/20001/components/sync/protoco...
> components/sync/protocol/user_event_specifics.proto:48: enum Interaction {
> You also need:
> 
> - never translate language
> - never translate site
> - always translate language
> - translation reverted
> - automatic translation

For the first three, we can get the current value of that from sync data e.g.
translate_whitelists, translate_blocked_languages, translate_site_blacklist.

[renjieliu1, 2017-05-29 00:46:00]

https://codereview.chromium.org/2911603002/diff/20001/components/sync/protoco...
File components/sync/protocol/user_event_specifics.proto (right):

https://codereview.chromium.org/2911603002/diff/20001/components/sync/protoco...
components/sync/protocol/user_event_specifics.proto:48: enum Interaction {
On 2017/05/29 00:23:49, napper wrote:
> You also need:
> 
> - never translate language
> - never translate site
> - always translate language
> - translation reverted
> - automatic translation

Done.

[renjieliu1, 2017-05-31 07:09:32]

renjieliu@chromium.org changed reviewers:
+ skym@chromium.org

[renjieliu1, 2017-05-31 07:10:22]

Hi Sky,

We're doing client side logging for translation event as well. PTAL.

Thanks a lot!

[skym, 2017-05-31 22:40:09]

lgtm

[renjieliu1, 2017-05-31 23:43:22]

The CQ bit was checked by renjieliu@chromium.org

[renjieliu1, 2017-05-31 23:43:23]

The patchset sent to the CQ was uploaded after l-g-t-m from amoylan@chromium.org
Link to the patchset: https://codereview.chromium.org/2911603002/#ps60001
(title: "update fields.")

[commit-bot: I haz the power, 2017-05-31 23:44:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 00:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 00:55:19]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[renjieliu1, 2017-06-01 03:35:11]

The CQ bit was checked by renjieliu@chromium.org

[commit-bot: I haz the power, 2017-06-01 03:35:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 03:39:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496288111721030,
"parent_rev": "7cf104a50a7131c2359d7975e7007e9e661e07cd", "commit_rev":
"eb3d357883dd94b2875bfeeb2e1a5b4ad7ce7b6e"}

[commit-bot: I haz the power, 2017-06-01 03:39:58]

Description was changed from

==========
Initial translation event proto.

Design doc:
https://docs.google.com/document/d/1-q-vrxqNZDnwajpOwMWB_Z1YlzQUiApJZmSUzGkoj...

Integration Steps:
https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_...

BUG=
==========

to

==========
Initial translation event proto.

Design doc:
https://docs.google.com/document/d/1-q-vrxqNZDnwajpOwMWB_Z1YlzQUiApJZmSUzGkoj...

Integration Steps:
https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_...

BUG=

Review-Url: https://codereview.chromium.org/2911603002
Cr-Commit-Position: refs/heads/master@{#476174}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb3d357883dd94b2875bfeeb2e1a...
==========

[commit-bot: I haz the power, 2017-06-01 03:39:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/eb3d357883dd94b2875bfeeb2e1a...