Remove hover highlight on Harmony checkboxes.

Remove hover highlight on Harmony checkboxes.

As per the Harmony spec, checkboxes now do nothing on hover but still have
the activation ripple on click. Pre-Harmony checkboxes have disabled ink
drops, so this won't affect them.

BUG=652510
Review-Url: https://codereview.chromium.org/2911573002
Cr-Commit-Position: refs/heads/master@{#475201}
Committed: https://chromium.googlesource.com/chromium/src/+/b6883a0122ecf806bc8ced8016bab4beca0c2d74

[Bret, 2017-05-25 23:42:06]

Description was changed from

==========
Remove hover highlight on Harmony checkboxes.

As per the Harmony spec, checkboxes now do nothing on hover but still
have the activation ripple on click.

BUG=652510
==========

to

==========
Remove hover highlight on Harmony checkboxes.

As per the Harmony spec, checkboxes now do nothing on hover but still
have the activation ripple on click.

BUG=652510
==========

[Bret, 2017-05-25 23:42:07]

bsep@chromium.org changed reviewers:
+ sky@chromium.org

[Bret, 2017-05-25 23:44:21]

Description was changed from

==========
Remove hover highlight on Harmony checkboxes.

As per the Harmony spec, checkboxes now do nothing on hover but still
have the activation ripple on click.

BUG=652510
==========

to

==========
Remove hover highlight on Harmony checkboxes.

As per the Harmony spec, checkboxes now do nothing on hover but still have
the activation ripple on click. Pre-Harmony checkboxes have disabled ink
drops, so this won't affect them.

BUG=652510
==========

[sky, 2017-05-26 02:28:55]

https://codereview.chromium.org/2911573002/diff/40001/ui/views/controls/butto...
File ui/views/controls/button/checkbox.cc (right):

https://codereview.chromium.org/2911573002/diff/40001/ui/views/controls/butto...
ui/views/controls/button/checkbox.cc:175: return nullptr;
Is harmony the default everywhere not? If not, won't it effect *all* checkboxs,
not just harmony?

[Bret, 2017-05-26 19:58:26]

https://codereview.chromium.org/2911573002/diff/40001/ui/views/controls/butto...
File ui/views/controls/button/checkbox.cc (right):

https://codereview.chromium.org/2911573002/diff/40001/ui/views/controls/butto...
ui/views/controls/button/checkbox.cc:175: return nullptr;
On 2017/05/26 02:28:54, sky wrote:
> Is harmony the default everywhere not? If not, won't it effect *all*
checkboxs,
> not just harmony? 

Harmony isn't on by default yet. Checkboxes don't have an ink drop when harmony
is off, so this won't affect users until we launch. When Harmony is on it will
affect all views checkboxes, but we want them to look the same everywhere and
without this hover effect.

I double-checked that this is true in my testing.

[sky, 2017-05-26 22:07:41]

sky@chromium.org changed reviewers:
+ bruthig@chromium.org

[sky, 2017-05-26 22:07:41]

Ok, LGTM

[Bret, 2017-05-26 23:17:22]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-05-26 23:18:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 01:26:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495840642614400,
"parent_rev": "bec7087d3eb468bed72e4e39478edf7c57acf298", "commit_rev":
"0b5068a4cc86f7a96db95dc19234808a067c8fc3"}

[commit-bot: I haz the power, 2017-05-27 01:27:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495840642614400,
"parent_rev": "cce9139c917337f414d6b3777ded5458f32746c1", "commit_rev":
"e18560957f141c69948c280eebaf5d27d7679c67"}

[commit-bot: I haz the power, 2017-05-27 01:27:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495840642614400,
"parent_rev": "74f13ec6e3db8c518ade6a16fa93bd0daabd1d20", "commit_rev":
"b6883a0122ecf806bc8ced8016bab4beca0c2d74"}

[commit-bot: I haz the power, 2017-05-27 01:27:39]

Description was changed from

==========
Remove hover highlight on Harmony checkboxes.

As per the Harmony spec, checkboxes now do nothing on hover but still have
the activation ripple on click. Pre-Harmony checkboxes have disabled ink
drops, so this won't affect them.

BUG=652510
==========

to

==========
Remove hover highlight on Harmony checkboxes.

As per the Harmony spec, checkboxes now do nothing on hover but still have
the activation ripple on click. Pre-Harmony checkboxes have disabled ink
drops, so this won't affect them.

BUG=652510

Review-Url: https://codereview.chromium.org/2911573002
Cr-Commit-Position: refs/heads/master@{#475201}
Committed:
https://chromium.googlesource.com/chromium/src/+/b6883a0122ecf806bc8ced8016ba...
==========

[commit-bot: I haz the power, 2017-05-27 01:27:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b6883a0122ecf806bc8ced8016ba...