Remove hover highlight on Harmony checkboxes.

ui/views/controls/button/checkbox.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/checkbox.h"
 
 #include <stddef.h>
 
 #include <utility>
 
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/resources/grit/ui_resources.h"
+#include "ui/views/animation/ink_drop_highlight.h"
 #include "ui/views/animation/ink_drop_ripple.h"
 #include "ui/views/animation/square_ink_drop_ripple.h"
 #include "ui/views/controls/button/label_button_border.h"
 #include "ui/views/painter.h"
 #include "ui/views/resources/grit/views_resources.h"
 #include "ui/views/style/platform_style.h"
 #include "ui/views/vector_icons.h"
 
 namespace views {
 
@@ skipping 134 matching lines @@
 std::unique_ptr<InkDropRipple> Checkbox::CreateInkDropRipple() const {
   // The "small" size is 21dp, the large size is 1.33 * 21dp = 28dp.
   const gfx::Size size(21, 21);
   std::unique_ptr<InkDropRipple> ripple(new SquareInkDropRipple(
       CalculateLargeInkDropSize(size), kInkDropLargeCornerRadius, size,
       kInkDropSmallCornerRadius, image()->GetMirroredBounds().CenterPoint(),
       GetInkDropBaseColor(), ink_drop_visible_opacity()));
   return ripple;
 }
 
+std::unique_ptr<views::InkDropHighlight> Checkbox::CreateInkDropHighlight()
+    const {
+  return nullptr;

[sky, 2017/05/26 02:28:54]

Is harmony the default everywhere not? If not, won't it effect *all* checkboxs,
not just harmony? 

[Bret, 2017/05/26 19:58:25]

Harmony isn't on by default yet. Checkboxes don't have an ink drop when harmony
is off, so this won't affect users until we launch. When Harmony is on it will
affect all views checkboxes, but we want them to look the same everywhere and
without this hover effect.

I double-checked that this is true in my testing.

+}
+
 SkColor Checkbox::GetInkDropBaseColor() const {
   return GetNativeTheme()->GetSystemColor(
       ui::NativeTheme::kColorId_ButtonEnabledColor);
 }
 
 gfx::ImageSkia Checkbox::GetImage(ButtonState for_state) const {
   if (UseMd()) {
     return gfx::CreateVectorIcon(
         GetVectorIcon(), 16,
         // When not checked, the icon color matches the button text color.
@@ skipping 38 matching lines @@
 ui::NativeTheme::Part Checkbox::GetThemePart() const {
   return ui::NativeTheme::kCheckbox;
 }
 
 void Checkbox::GetExtraParams(ui::NativeTheme::ExtraParams* params) const {
   LabelButton::GetExtraParams(params);
   params->button.checked = checked_;
 }
 
 }  // namespace views