Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Issue 291153008: [Telemetry] Remove "_by_url" string from page-specific results. (Closed)

Created:
6 years, 7 months ago by tonyg
Modified:
6 years, 7 months ago
Reviewers:
qyearsley
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] Remove "_by_url" string from page-specific results. The dashboard no longer needs this hack and in fact it is breaking our ability to bisect in some cases. BUG=371159 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -69 lines) Patch
M tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py View 11 chunks +45 lines, -45 lines 0 comments Download
M tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py View 8 chunks +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/__init__.py View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/value/scalar_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/string_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/summary.py View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
Please feel free to cq this if you're happy w/ it.
6 years, 7 months ago (2014-05-21 08:40:05 UTC) #1
qyearsley
On 2014/05/21 08:40:05, tonyg wrote: > Please feel free to cq this if you're happy ...
6 years, 7 months ago (2014-05-21 16:54:05 UTC) #2
qyearsley
The CQ bit was checked by qyearsley@chromium.org
6 years, 7 months ago (2014-05-21 16:54:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/291153008/1
6 years, 7 months ago (2014-05-21 19:58:59 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 03:49:45 UTC) #5
Message was sent while issue was closed.
Change committed as 272079

Powered by Google App Engine
This is Rietveld 408576698