tools/telemetry/telemetry/value/__init__.py - Issue 291153008: [Telemetry] Remove "_by_url" string from page-specific results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/init.py

Issue 291153008: [Telemetry] Remove "_by_url" string from page-specific results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/value/__init__.py

diff --git a/tools/telemetry/telemetry/value/__init__.py b/tools/telemetry/telemetry/value/__init__.py

index 80a2269897a5a8d43d6fc1edd0f2ae11e041509c..99d35717b15cf032320e22e22b2f7504c813be76 100644

--- a/tools/telemetry/telemetry/value/__init__.py

+++ b/tools/telemetry/telemetry/value/__init__.py

@@ -116,9 +116,8 @@ class Value(object):

raise NotImplementedError()

def GetBuildbotMeasurementAndTraceNameForPerPageResult(self):

- measurement, _ = (

- _ConvertValueNameToBuildbotChartAndTraceName(self.name))

- return measurement + '_by_url', self.page.display_name

+ measurement, _ = _ConvertValueNameToBuildbotChartAndTraceName(self.name)

+ return measurement, self.page.display_name

@property

def name_suffix(self):

« no previous file with comments | « tools/telemetry/telemetry/page/page_runner_unittest.py ('k') | tools/telemetry/telemetry/value/scalar_unittest.py » ('j') | no next file with comments »

Unified Diff: tools/telemetry/telemetry/value/__init__.py

Unified Diff: tools/telemetry/telemetry/value/init.py