tools/telemetry/telemetry/page/page_runner_unittest.py - Issue 291153008: [Telemetry] Remove "_by_url" string from page-specific results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 291153008: [Telemetry] Remove "_by_url" string from page-specific results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py ('k') | tools/telemetry/telemetry/value/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_runner_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py

index b3b2384691e4f9cb8bf4c97f1191c68ab35173cf..862507d0d4a077b71bfaba94c02c741a0685c71b 100644

--- a/tools/telemetry/telemetry/page/page_runner_unittest.py

+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py

@@ -234,8 +234,8 @@ class PageRunnerTests(unittest.TestCase):

self.assertEquals(0, len(results.failures))

with open(output_file) as f:

stdout = f.read()

- self.assertIn('RESULT metric_by_url: blank.html= [1,3] unit', stdout)

- self.assertIn('RESULT metric_by_url: green_rect.html= [2,4] unit', stdout)

+ self.assertIn('RESULT metric: blank.html= [1,3] unit', stdout)

+ self.assertIn('RESULT metric: green_rect.html= [2,4] unit', stdout)

self.assertIn('*RESULT metric: metric= [1,2,3,4] unit', stdout)

finally:

results._output_stream.close() # pylint: disable=W0212