 Chromium Code Reviews
 Chromium Code Reviews Issue 2911513002:
  Partition libcxx build code from build/config/sanitizers  (Closed)
    
  
    Issue 2911513002:
  Partition libcxx build code from build/config/sanitizers  (Closed) 
  | Index: components/nacl/loader/nacl_helper_linux.cc | 
| diff --git a/components/nacl/loader/nacl_helper_linux.cc b/components/nacl/loader/nacl_helper_linux.cc | 
| index df24f6d6181b5c03e8d9d4b95b8191e98f0d1d44..fbce5f9c989287459a495a86d64b07be4c290b40 100644 | 
| --- a/components/nacl/loader/nacl_helper_linux.cc | 
| +++ b/components/nacl/loader/nacl_helper_linux.cc | 
| @@ -411,21 +411,8 @@ static size_t CheckReservedAtZero() { | 
| // Do not install the SIGSEGV handler in ASan. This should make the NaCl | 
| // platform qualification test pass. | 
| // detect_odr_violation=0: http://crbug.com/376306 | 
| -static const char kAsanDefaultOptionsNaCl[] = | 
| - "handle_segv=0:detect_odr_violation=0"; | 
| - | 
| -// Override the default ASan options for the NaCl helper. | 
| -// __asan_default_options should not be instrumented, because it is called | 
| -// before ASan is initialized. | 
| -extern "C" | 
| -__attribute__((no_sanitize_address)) | 
| 
bradnelson
2017/05/26 17:52:43
Why isn't this needed anymore?
(This executable ge
 | 
| -// The function isn't referenced from the executable itself. Make sure it isn't | 
| -// stripped by the linker. | 
| -__attribute__((used)) | 
| -__attribute__((visibility("default"))) | 
| -const char* __asan_default_options() { | 
| - return kAsanDefaultOptionsNaCl; | 
| -} | 
| +extern const char* kAsanDefaultOptionsNaCl; | 
| +const char* kAsanDefaultOptionsNaCl = "handle_segv=0:detect_odr_violation=0"; | 
| #endif | 
| int main(int argc, char* argv[]) { |