Partition libcxx build code from build/config/sanitizers

Partition libcxx build code from build/config/sanitizers

This CL:
* Removes the last dependency on sanitizers:deps_no_options and replaces it
  with exe_and_shlib_deps
* Merges sanitizers:deps and sanitizers:deps_no_options
* Adds a weak symbol for NaCl to override the default sanitizer options

BUG=593874
R=thakis@chromium.org,bradnelson@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng

Review-Url: https://codereview.chromium.org/2911513002
Cr-Commit-Position: refs/heads/master@{#475093}
Committed: https://chromium.googlesource.com/chromium/src/+/f59081471b68cb0a0c484fe9c9c3b8a1f7f2d122

[Tom Anderson, 2017-05-25 22:17:04]

Description was changed from

==========
Experimental change [DO NOT LAND]
==========

to

==========
Experimental change [DO NOT LAND]

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

[Tom Anderson, 2017-05-25 22:17:13]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 22:18:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-05-25 22:24:12]

Patchset #2 (id:20001) has been deleted

[Tom Anderson, 2017-05-25 22:24:15]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 22:25:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-05-25 22:30:41]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 22:31:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 22:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 22:44:18]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Tom Anderson, 2017-05-25 22:50:06]

Patchset #3 (id:60001) has been deleted

[Tom Anderson, 2017-05-25 22:53:12]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[Tom Anderson, 2017-05-25 22:53:16]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-05-25 22:54:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 23:39:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 23:39:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom Anderson, 2017-05-26 01:54:16]

Patchset #3 (id:100001) has been deleted

[Tom Anderson, 2017-05-26 01:54:46]

Description was changed from

==========
Experimental change [DO NOT LAND]

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

to

==========
Experimental change [DO NOT LAND]

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

[Tom Anderson, 2017-05-26 01:54:52]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 01:56:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-05-26 02:14:34]

Description was changed from

==========
Experimental change [DO NOT LAND]

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

to

==========
Experimental change [DO NOT LAND]

BUG=593874
R=thakis@chromium.org,bradnelson@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

[Tom Anderson, 2017-05-26 02:14:35]

thomasanderson@chromium.org changed reviewers:
+ bradnelson@chromium.org, thakis@chromium.org

[commit-bot: I haz the power, 2017-05-26 05:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 05:43:55]

Dry run: This issue passed the CQ dry run.

[Tom Anderson, 2017-05-26 17:09:58]

Description was changed from

==========
Experimental change [DO NOT LAND]

BUG=593874
R=thakis@chromium.org,bradnelson@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

to

==========
Partition libcxx dependency from build/config/sanitizers



BUG=593874
R=thakis@chromium.org,bradnelson@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

[Tom Anderson, 2017-05-26 17:14:28]

Description was changed from

==========
Partition libcxx dependency from build/config/sanitizers



BUG=593874
R=thakis@chromium.org,bradnelson@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

to

==========
Partition libcxx dependency from build/config/sanitizers

This CL:
* Removes the last dependency on sanitizers:deps_no_options and replaces it
  with exe_and_shlib_deps
* Merges sanitizers:deps and sanitizers:deps_no_options
* Adds a weak symbol for NaCl to override the default sanitizer options

BUG=593874
R=thakis@chromium.org,bradnelson@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

[Tom Anderson, 2017-05-26 17:15:24]

reviewers ptal

thakis: build/config
bradnelson: nacl

[Tom Anderson, 2017-05-26 17:20:36]

Description was changed from

==========
Partition libcxx dependency from build/config/sanitizers

This CL:
* Removes the last dependency on sanitizers:deps_no_options and replaces it
  with exe_and_shlib_deps
* Merges sanitizers:deps and sanitizers:deps_no_options
* Adds a weak symbol for NaCl to override the default sanitizer options

BUG=593874
R=thakis@chromium.org,bradnelson@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

to

==========
Partition libcxx build code from build/config/sanitizers

This CL:
* Removes the last dependency on sanitizers:deps_no_options and replaces it
  with exe_and_shlib_deps
* Merges sanitizers:deps and sanitizers:deps_no_options
* Adds a weak symbol for NaCl to override the default sanitizer options

BUG=593874
R=thakis@chromium.org,bradnelson@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

[bradnelson, 2017-05-26 17:52:43]

https://codereview.chromium.org/2911513002/diff/120001/components/nacl/loader...
File components/nacl/loader/nacl_helper_linux.cc (left):

https://codereview.chromium.org/2911513002/diff/120001/components/nacl/loader...
components/nacl/loader/nacl_helper_linux.cc:421:
__attribute__((no_sanitize_address))
Why isn't this needed anymore?
(This executable gets crazy stuff done to it)

[Nico, 2017-05-26 18:44:20]

The non-nacl bits lgtm

[Tom Anderson, 2017-05-26 19:06:23]

On 2017/05/26 17:52:43, bradnelson wrote:
>
https://codereview.chromium.org/2911513002/diff/120001/components/nacl/loader...
> File components/nacl/loader/nacl_helper_linux.cc (left):
> 
>
https://codereview.chromium.org/2911513002/diff/120001/components/nacl/loader...
> components/nacl/loader/nacl_helper_linux.cc:421:
> __attribute__((no_sanitize_address))
> Why isn't this needed anymore?
> (This executable gets crazy stuff done to it)

It is still needed.  Take a look at build/sanitizers/sanitizer_options.cc
This CL allows NaCl to override the default asan options

[bradnelson, 2017-05-26 19:17:56]

Ah ok.
lgtm

[Tom Anderson, 2017-05-26 19:26:18]

The CQ bit was checked by thomasanderson@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:26:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 20:01:42]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495826778137560,
"parent_rev": "35be3092e0e4591024a4d3fa47b00160d3da1f79", "commit_rev":
"f59081471b68cb0a0c484fe9c9c3b8a1f7f2d122"}

[commit-bot: I haz the power, 2017-05-26 20:04:34]

Description was changed from

==========
Partition libcxx build code from build/config/sanitizers

This CL:
* Removes the last dependency on sanitizers:deps_no_options and replaces it
  with exe_and_shlib_deps
* Merges sanitizers:deps and sanitizers:deps_no_options
* Adds a weak symbol for NaCl to override the default sanitizer options

BUG=593874
R=thakis@chromium.org,bradnelson@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
==========

to

==========
Partition libcxx build code from build/config/sanitizers

This CL:
* Removes the last dependency on sanitizers:deps_no_options and replaces it
  with exe_and_shlib_deps
* Merges sanitizers:deps and sanitizers:deps_no_options
* Adds a weak symbol for NaCl to override the default sanitizer options

BUG=593874
R=thakis@chromium.org,bradnelson@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng

Review-Url: https://codereview.chromium.org/2911513002
Cr-Commit-Position: refs/heads/master@{#475093}
Committed:
https://chromium.googlesource.com/chromium/src/+/f59081471b68cb0a0c484fe9c9c3...
==========

[commit-bot: I haz the power, 2017-05-26 20:04:35]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/f59081471b68cb0a0c484fe9c9c3...