Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2911403002: Rename StyleRareNonInheritedData members. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
dstockwell
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename StyleRareNonInheritedData members. This patch renames some StyleRareNonInheritedData members so that they match the format expected by the generator. BUG=628043 Review-Url: https://codereview.chromium.org/2911403002 Cr-Commit-Position: refs/heads/master@{#475814} Committed: https://chromium.googlesource.com/chromium/src/+/22b71109df3859c446a21a1fefccec0d70b5d52c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -54 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 7 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 6 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-30 23:48:49 UTC) #3
shend
Hi Doug, PTAL
3 years, 6 months ago (2017-05-31 04:24:32 UTC) #8
dstockwell
lgtm
3 years, 6 months ago (2017-05-31 05:25:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911403002/1
3 years, 6 months ago (2017-05-31 05:33:20 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 05:37:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/22b71109df3859c446a21a1fefcc...

Powered by Google App Engine
This is Rietveld 408576698