Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2911403002: Rename StyleRareNonInheritedData members. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
4 * reserved. 4 * reserved.
5 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 5 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 // - don't need paint invalidation at all; 553 // - don't need paint invalidation at all;
554 // - or the layoutObject knows how to exactly invalidate paints caused by the 554 // - or the layoutObject knows how to exactly invalidate paints caused by the
555 // layout change instead of forced full paint invalidation. 555 // layout change instead of forced full paint invalidation.
556 556
557 if (ComputedStyleBase::DiffNeedsFullLayoutAndPaintInvalidation(other)) 557 if (ComputedStyleBase::DiffNeedsFullLayoutAndPaintInvalidation(other))
558 return true; 558 return true;
559 559
560 if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) { 560 if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
561 if (rare_non_inherited_data_->appearance_ != 561 if (rare_non_inherited_data_->appearance_ !=
562 other.rare_non_inherited_data_->appearance_ || 562 other.rare_non_inherited_data_->appearance_ ||
563 rare_non_inherited_data_->margin_before_collapse != 563 rare_non_inherited_data_->margin_before_collapse_ !=
564 other.rare_non_inherited_data_->margin_before_collapse || 564 other.rare_non_inherited_data_->margin_before_collapse_ ||
565 rare_non_inherited_data_->margin_after_collapse != 565 rare_non_inherited_data_->margin_after_collapse_ !=
566 other.rare_non_inherited_data_->margin_after_collapse || 566 other.rare_non_inherited_data_->margin_after_collapse_ ||
567 rare_non_inherited_data_->line_clamp != 567 rare_non_inherited_data_->line_clamp_ !=
568 other.rare_non_inherited_data_->line_clamp || 568 other.rare_non_inherited_data_->line_clamp_ ||
569 rare_non_inherited_data_->text_overflow != 569 rare_non_inherited_data_->text_overflow_ !=
570 other.rare_non_inherited_data_->text_overflow || 570 other.rare_non_inherited_data_->text_overflow_ ||
571 rare_non_inherited_data_->shape_margin_ != 571 rare_non_inherited_data_->shape_margin_ !=
572 other.rare_non_inherited_data_->shape_margin_ || 572 other.rare_non_inherited_data_->shape_margin_ ||
573 rare_non_inherited_data_->order_ != 573 rare_non_inherited_data_->order_ !=
574 other.rare_non_inherited_data_->order_ || 574 other.rare_non_inherited_data_->order_ ||
575 HasFilters() != other.HasFilters()) 575 HasFilters() != other.HasFilters())
576 return true; 576 return true;
577 577
578 if (rare_non_inherited_data_->grid_.Get() != 578 if (rare_non_inherited_data_->grid_.Get() !=
579 other.rare_non_inherited_data_->grid_.Get() && 579 other.rare_non_inherited_data_->grid_.Get() &&
580 *rare_non_inherited_data_->grid_.Get() != 580 *rare_non_inherited_data_->grid_.Get() !=
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
728 bool ComputedStyle::DiffNeedsPaintInvalidationObject( 728 bool ComputedStyle::DiffNeedsPaintInvalidationObject(
729 const ComputedStyle& other) const { 729 const ComputedStyle& other) const {
730 if (ComputedStyleBase::DiffNeedsPaintInvalidationObject(other)) 730 if (ComputedStyleBase::DiffNeedsPaintInvalidationObject(other))
731 return true; 731 return true;
732 732
733 if (!BorderVisuallyEqual(other) || !RadiiEqual(other) || 733 if (!BorderVisuallyEqual(other) || !RadiiEqual(other) ||
734 *background_data_ != *other.background_data_) 734 *background_data_ != *other.background_data_)
735 return true; 735 return true;
736 736
737 if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) { 737 if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
738 if (rare_non_inherited_data_->user_drag != 738 if (rare_non_inherited_data_->user_drag_ !=
739 other.rare_non_inherited_data_->user_drag || 739 other.rare_non_inherited_data_->user_drag_ ||
740 rare_non_inherited_data_->object_fit_ != 740 rare_non_inherited_data_->object_fit_ !=
741 other.rare_non_inherited_data_->object_fit_ || 741 other.rare_non_inherited_data_->object_fit_ ||
742 rare_non_inherited_data_->object_position_ != 742 rare_non_inherited_data_->object_position_ !=
743 other.rare_non_inherited_data_->object_position_ || 743 other.rare_non_inherited_data_->object_position_ ||
744 !BoxShadowDataEquivalent(other) || !ShapeOutsideDataEquivalent(other) || 744 !BoxShadowDataEquivalent(other) || !ShapeOutsideDataEquivalent(other) ||
745 !ClipPathDataEquivalent(other) || 745 !ClipPathDataEquivalent(other) ||
746 !rare_non_inherited_data_->outline_.VisuallyEqual( 746 !rare_non_inherited_data_->outline_.VisuallyEqual(
747 other.rare_non_inherited_data_->outline_) || 747 other.rare_non_inherited_data_->outline_) ||
748 (VisitedLinkBorderLeftColor() != other.VisitedLinkBorderLeftColor() && 748 (VisitedLinkBorderLeftColor() != other.VisitedLinkBorderLeftColor() &&
749 BorderLeftWidth()) || 749 BorderLeftWidth()) ||
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
835 if (HasTransform() != other.HasTransform() || 835 if (HasTransform() != other.HasTransform() ||
836 !TransformDataEquivalent(other) || 836 !TransformDataEquivalent(other) ||
837 rare_non_inherited_data_->perspective_ != 837 rare_non_inherited_data_->perspective_ !=
838 other.rare_non_inherited_data_->perspective_ || 838 other.rare_non_inherited_data_->perspective_ ||
839 rare_non_inherited_data_->perspective_origin_ != 839 rare_non_inherited_data_->perspective_origin_ !=
840 other.rare_non_inherited_data_->perspective_origin_) 840 other.rare_non_inherited_data_->perspective_origin_)
841 diff.SetTransformChanged(); 841 diff.SetTransformChanged();
842 } 842 }
843 843
844 if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) { 844 if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
845 if (rare_non_inherited_data_->opacity != 845 if (rare_non_inherited_data_->opacity_ !=
846 other.rare_non_inherited_data_->opacity) 846 other.rare_non_inherited_data_->opacity_)
847 diff.SetOpacityChanged(); 847 diff.SetOpacityChanged();
848 } 848 }
849 849
850 if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) { 850 if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
851 if ((rare_non_inherited_data_->filter_ != 851 if ((rare_non_inherited_data_->filter_ !=
852 other.rare_non_inherited_data_->filter_) || 852 other.rare_non_inherited_data_->filter_) ||
853 !ReflectionDataEquivalent(other)) 853 !ReflectionDataEquivalent(other))
854 diff.SetFilterChanged(); 854 diff.SetFilterChanged();
855 } 855 }
856 856
(...skipping 1477 matching lines...) Expand 10 before | Expand all | Expand 10 after
2334 if (value < 0) 2334 if (value < 0)
2335 fvalue -= 0.5f; 2335 fvalue -= 0.5f;
2336 else 2336 else
2337 fvalue += 0.5f; 2337 fvalue += 0.5f;
2338 } 2338 }
2339 2339
2340 return RoundForImpreciseConversion<int>(fvalue / zoom_factor); 2340 return RoundForImpreciseConversion<int>(fvalue / zoom_factor);
2341 } 2341 }
2342 2342
2343 } // namespace blink 2343 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698