DescriptionExplicitly generate ComputedStyleBase subgroup copy constructors.
We currently use the default copy constructor for subgroups under
ComputedStyleBase like StyleSurroundData. We've been able to do so
because all fields had default copying behaviour. Now we want to
generate StyleRareNonInheritedData, which has std::unique_ptr fields
that cannot be copied by default. This means we have to explicitly
generate user-defined copy constructors for these subgroups.
This is in preparation for supporting custom copying behaviour for
fields.
Diff of generated files:
https://gist.github.com/darrnshn/1c51e498c11b2798fbc962390a009060/revisions
BUG=628043
Review-Url: https://codereview.chromium.org/2911373002
Cr-Commit-Position: refs/heads/master@{#475788}
Committed: https://chromium.googlesource.com/chromium/src/+/4345e38cd114d781b630039d2cc0f18c7514f626
Patch Set 1 #
Messages
Total messages: 14 (10 generated)
|