Explicitly generate ComputedStyleBase subgroup copy constructors.

Explicitly generate ComputedStyleBase subgroup copy constructors.

We currently use the default copy constructor for subgroups under
ComputedStyleBase like StyleSurroundData. We've been able to do so
because all fields had default copying behaviour. Now we want to
generate StyleRareNonInheritedData, which has std::unique_ptr fields
that cannot be copied by default. This means we have to explicitly
generate user-defined copy constructors for these subgroups.

This is in preparation for supporting custom copying behaviour for
fields.

Diff of generated files:
https://gist.github.com/darrnshn/1c51e498c11b2798fbc962390a009060/revisions

BUG=628043
Review-Url: https://codereview.chromium.org/2911373002
Cr-Commit-Position: refs/heads/master@{#475788}
Committed: https://chromium.googlesource.com/chromium/src/+/4345e38cd114d781b630039d2cc0f18c7514f626

[shend, 2017-05-30 22:52:33]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[shend, 2017-05-30 22:53:00]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-05-30 22:53:01]

Hi Naina, PTAL

[commit-bot: I haz the power, 2017-05-30 22:53:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-30 22:53:48]

Description was changed from

==========
Explicitly generate ComputedStyleBase subgroup copy constructors.

We currently use the default copy constructor for subgroups under
ComputedStyleBase like StyleSurroundData. We've been able to do so
because all fields had default copying behaviour. Now we want to
generate StyleRareNonInheritedData, which has std::unique_ptr fields
that cannot be copied by default. This means we have to explicitly
generate user-defined copy constructors for these subgroups.

BUG=628043
==========

to

==========
Explicitly generate ComputedStyleBase subgroup copy constructors.

We currently use the default copy constructor for subgroups under
ComputedStyleBase like StyleSurroundData. We've been able to do so
because all fields had default copying behaviour. Now we want to
generate StyleRareNonInheritedData, which has std::unique_ptr fields
that cannot be copied by default. This means we have to explicitly
generate user-defined copy constructors for these subgroups.

Diff of generated files:
https://gist.github.com/darrnshn/1c51e498c11b2798fbc962390a009060/revisions

BUG=628043
==========

[shend, 2017-05-30 22:54:25]

Description was changed from

==========
Explicitly generate ComputedStyleBase subgroup copy constructors.

We currently use the default copy constructor for subgroups under
ComputedStyleBase like StyleSurroundData. We've been able to do so
because all fields had default copying behaviour. Now we want to
generate StyleRareNonInheritedData, which has std::unique_ptr fields
that cannot be copied by default. This means we have to explicitly
generate user-defined copy constructors for these subgroups.

Diff of generated files:
https://gist.github.com/darrnshn/1c51e498c11b2798fbc962390a009060/revisions

BUG=628043
==========

to

==========
Explicitly generate ComputedStyleBase subgroup copy constructors.

We currently use the default copy constructor for subgroups under
ComputedStyleBase like StyleSurroundData. We've been able to do so
because all fields had default copying behaviour. Now we want to
generate StyleRareNonInheritedData, which has std::unique_ptr fields
that cannot be copied by default. This means we have to explicitly
generate user-defined copy constructors for these subgroups.

This is in preparation for supporting custom copying behaviour for
fields.

Diff of generated files:
https://gist.github.com/darrnshn/1c51e498c11b2798fbc962390a009060/revisions

BUG=628043
==========

[nainar, 2017-05-31 00:07:50]

lgtm

[commit-bot: I haz the power, 2017-05-31 01:25:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 01:25:01]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-31 04:00:52]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-05-31 04:01:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 04:05:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496203252183870, "parent_rev":
"722818181b8815df6b493a906961f3933b25cddb", "commit_rev":
"4345e38cd114d781b630039d2cc0f18c7514f626"}

[commit-bot: I haz the power, 2017-05-31 04:05:45]

Description was changed from

==========
Explicitly generate ComputedStyleBase subgroup copy constructors.

We currently use the default copy constructor for subgroups under
ComputedStyleBase like StyleSurroundData. We've been able to do so
because all fields had default copying behaviour. Now we want to
generate StyleRareNonInheritedData, which has std::unique_ptr fields
that cannot be copied by default. This means we have to explicitly
generate user-defined copy constructors for these subgroups.

This is in preparation for supporting custom copying behaviour for
fields.

Diff of generated files:
https://gist.github.com/darrnshn/1c51e498c11b2798fbc962390a009060/revisions

BUG=628043
==========

to

==========
Explicitly generate ComputedStyleBase subgroup copy constructors.

We currently use the default copy constructor for subgroups under
ComputedStyleBase like StyleSurroundData. We've been able to do so
because all fields had default copying behaviour. Now we want to
generate StyleRareNonInheritedData, which has std::unique_ptr fields
that cannot be copied by default. This means we have to explicitly
generate user-defined copy constructors for these subgroups.

This is in preparation for supporting custom copying behaviour for
fields.

Diff of generated files:
https://gist.github.com/darrnshn/1c51e498c11b2798fbc962390a009060/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2911373002
Cr-Commit-Position: refs/heads/master@{#475788}
Committed:
https://chromium.googlesource.com/chromium/src/+/4345e38cd114d781b630039d2cc0...
==========

[commit-bot: I haz the power, 2017-05-31 04:05:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4345e38cd114d781b630039d2cc0...