Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2911203003: Print Preview: Migrate JS tests to use Mocha, part 3. (Closed)

Created:
3 years, 6 months ago by dpapad
Modified:
3 years, 6 months ago
Reviewers:
rbpotter
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Migrate JS tests to use Mocha, part 3. Migrating the following tests: ZeroTopAndBottomMarginsHideHeaderFooter ZeroTopAndNonZeroBottomMarginShowHeaderFooter SmallPaperSizeHeaderFooter TestColorSettingsMonochrome TestColorSettingsCustomMonochrome TestColorSettingsColor TestColorSettingsCustomColor TestColorSettingsBothStandardDefaultColor TestColorSettingsBothStandardDefaultMonochrome TestColorSettingsBothCustomDefaultColor Migrated tests 26, remaining tests 10. BUG=726536 Review-Url: https://codereview.chromium.org/2911203003 Cr-Commit-Position: refs/heads/master@{#476054} Committed: https://chromium.googlesource.com/chromium/src/+/cf195c35d5f9cd9c90b8688e1d9c50c4cfd5522e

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -369 lines) Patch
M chrome/test/data/webui/print_preview/print_preview.js View 1 chunk +0 lines, -282 lines 0 comments Download
M chrome/test/data/webui/print_preview/print_preview_tests.js View 1 1 chunk +287 lines, -20 lines 0 comments Download
M chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js View 1 2 1 chunk +32 lines, -67 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
dpapad
3 years, 6 months ago (2017-05-31 18:24:47 UTC) #6
rbpotter
lgtm
3 years, 6 months ago (2017-05-31 19:13:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911203003/40001
3 years, 6 months ago (2017-05-31 20:25:12 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 22:05:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf195c35d5f9cd9c90b8688e1d9c...

Powered by Google App Engine
This is Rietveld 408576698