Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2920593002: Print Preview: Migrate remaining JS tests to use Mocha. (Closed)

Created:
3 years, 6 months ago by dpapad
Modified:
3 years, 6 months ago
Reviewers:
rbpotter
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Migrate remaining JS tests to use Mocha. Migrating all remaining tests: DuplexSettingsTrue DuplexSettingsFalse PrinterChangeUpdatesPreview NoPDFPluginErrorMessage CustomPaperNames AdvancedSettings1Option AdvancedSettings2Options InitIssuesOneRequest InvalidSettingsError GenerateDraft BUG=726536 Review-Url: https://codereview.chromium.org/2920593002 Cr-Commit-Position: refs/heads/master@{#476182} Committed: https://chromium.googlesource.com/chromium/src/+/87c1fd7ea6e69c1d208a92301423b2bc7584bc97

Patch Set 1 : Rename again #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -773 lines) Patch
M chrome/test/data/webui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webui/print_preview/print_preview.js View 1 chunk +0 lines, -736 lines 0 comments Download
M chrome/test/data/webui/print_preview/print_preview_tests.js View 1 2 12 chunks +421 lines, -28 lines 0 comments Download
M chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js View 1 2 2 chunks +28 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
dpapad
3 years, 6 months ago (2017-05-31 22:33:39 UTC) #13
rbpotter
lgtm with one question (and related comments inline): is there a reason the accessibility issues ...
3 years, 6 months ago (2017-05-31 23:28:25 UTC) #14
dpapad
Restored accessibility checks to match the previous version of the code. https://codereview.chromium.org/2920593002/diff/60001/chrome/test/data/webui/print_preview/print_preview_tests.js File chrome/test/data/webui/print_preview/print_preview_tests.js (right): ...
3 years, 6 months ago (2017-06-01 00:29:48 UTC) #16
rbpotter
LGTM, thanks for updating.
3 years, 6 months ago (2017-06-01 01:25:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920593002/80001
3 years, 6 months ago (2017-06-01 01:32:50 UTC) #21
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 03:57:14 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/87c1fd7ea6e69c1d208a92301423...

Powered by Google App Engine
This is Rietveld 408576698