Print Preview: Migrate remaining JS tests to use Mocha.

Print Preview: Migrate remaining JS tests to use Mocha.

Migrating all remaining tests:

DuplexSettingsTrue
DuplexSettingsFalse
PrinterChangeUpdatesPreview
NoPDFPluginErrorMessage
CustomPaperNames
AdvancedSettings1Option
AdvancedSettings2Options
InitIssuesOneRequest
InvalidSettingsError
GenerateDraft

BUG=726536
Review-Url: https://codereview.chromium.org/2920593002
Cr-Commit-Position: refs/heads/master@{#476182}
Committed: https://chromium.googlesource.com/chromium/src/+/87c1fd7ea6e69c1d208a92301423b2bc7584bc97

[dpapad, 2017-05-31 21:08:08]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 21:08:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-05-31 21:11:57]

Description was changed from

==========
Print Preview: Migrate remaining JS tests to use Mocha.

Migrating all remaining tests:

TestDuplexSettingsTrue
TestDuplexSettingsFalse
TestPrinterChangeUpdatesPreview
TestNoPDFPluginErrorMessage
TestCustomPaperNames
TestAdvancedSettings1Option
TestAdvancedSettings2Options
TestInitIssuesOneRequest
TestInvalidSettingsError
TestGenerateDraft

BUG=726536
==========

to

==========
Print Preview: Migrate remaining JS tests to use Mocha.

Migrating all remaining tests:

DuplexSettingsTrue
DuplexSettingsFalse
PrinterChangeUpdatesPreview
NoPDFPluginErrorMessage
CustomPaperNames
AdvancedSettings1Option
AdvancedSettings2Options
InitIssuesOneRequest
InvalidSettingsError
GenerateDraft

BUG=726536
==========

[dpapad, 2017-05-31 21:12:05]

Patchset #2 (id:20001) has been deleted

[dpapad, 2017-05-31 21:12:09]

Patchset #1 (id:1) has been deleted

[dpapad, 2017-05-31 21:12:15]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 21:13:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 21:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:18:33]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dpapad, 2017-05-31 22:13:34]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 22:14:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-05-31 22:33:38]

dpapad@chromium.org changed reviewers:
+ rbpotter@chromium.org

[rbpotter, 2017-05-31 23:28:25]

lgtm with one question (and related comments inline): is
there a reason the accessibility issues as errors flag is off
for all tests now? As far as I know only the advanced
settings tests disabled this flag previously.

https://codereview.chromium.org/2920593002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/print_preview/print_preview_tests.js (right):

https://codereview.chromium.org/2920593002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview/print_preview_tests.js:203: // Need to
disable this since overlay animation will not fully complete.
Since all tests now run with accessibility issues as warnings turned off,
this comment is out of date. I should have moved it back in
http://crrev.com/2881213003 when I moved the code it corresponds to
into the tests, and now it appears to be entirely incorrect.

https://codereview.chromium.org/2920593002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
(right):

https://codereview.chromium.org/2920593002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js:28:
accessibilityIssuesAreErrors: false,
Maybe we should add a comment here about why accessibility checks
are not errors, to replace the inaccurate comment noted earlier
and to explain the change from the old tests.

[dpapad, 2017-06-01 00:29:17]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-06-01 00:29:48]

Restored accessibility checks to match the previous version of the code.

https://codereview.chromium.org/2920593002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/print_preview/print_preview_tests.js (right):

https://codereview.chromium.org/2920593002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview/print_preview_tests.js:203: // Need to
disable this since overlay animation will not fully complete.
On 2017/05/31 at 23:28:24, rbpotter wrote:
> Since all tests now run with accessibility issues as warnings turned off,
> this comment is out of date. I should have moved it back in
> http://crrev.com/2881213003 when I moved the code it corresponds to
> into the tests, and now it appears to be entirely incorrect.

Updated.

https://codereview.chromium.org/2920593002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
(right):

https://codereview.chromium.org/2920593002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js:28:
accessibilityIssuesAreErrors: false,
On 2017/05/31 at 23:28:24, rbpotter wrote:
> Maybe we should add a comment here about why accessibility checks
> are not errors, to replace the inaccurate comment noted earlier
> and to explain the change from the old tests.

I restored this value to true, and only turning it off for the same tests as
before.

[commit-bot: I haz the power, 2017-06-01 00:30:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-06-01 01:25:59]

LGTM, thanks for updating.

[dpapad, 2017-06-01 01:32:24]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2017-06-01 01:32:26]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-06-01 01:32:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 03:57:03]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496280746727300,
"parent_rev": "0c284454162c7b36d587707af42828f41336904f", "commit_rev":
"87c1fd7ea6e69c1d208a92301423b2bc7584bc97"}

[commit-bot: I haz the power, 2017-06-01 03:57:13]

Description was changed from

==========
Print Preview: Migrate remaining JS tests to use Mocha.

Migrating all remaining tests:

DuplexSettingsTrue
DuplexSettingsFalse
PrinterChangeUpdatesPreview
NoPDFPluginErrorMessage
CustomPaperNames
AdvancedSettings1Option
AdvancedSettings2Options
InitIssuesOneRequest
InvalidSettingsError
GenerateDraft

BUG=726536
==========

to

==========
Print Preview: Migrate remaining JS tests to use Mocha.

Migrating all remaining tests:

DuplexSettingsTrue
DuplexSettingsFalse
PrinterChangeUpdatesPreview
NoPDFPluginErrorMessage
CustomPaperNames
AdvancedSettings1Option
AdvancedSettings2Options
InitIssuesOneRequest
InvalidSettingsError
GenerateDraft

BUG=726536

Review-Url: https://codereview.chromium.org/2920593002
Cr-Commit-Position: refs/heads/master@{#476182}
Committed:
https://chromium.googlesource.com/chromium/src/+/87c1fd7ea6e69c1d208a92301423...
==========

[commit-bot: I haz the power, 2017-06-01 03:57:14]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/87c1fd7ea6e69c1d208a92301423...