[sync] Pull the Sieve implementation from FakeServer to LoopbackServer.

[sync] Pull the Sieve implementation from FakeServer to LoopbackServer.

This is a clone of https://codereview.chromium.org/2564663003 in
preparation for replacing the FakeServer impl with the LoopbackServer.
It should also improve the loopack server main purpose.

Original description of the clonned CL:
"Fake server now updates each model type's progress markers independently.

 Previously the fake server used to update all of the progress markers
 to the highest single version of an entity being returned in a
 GetUpdates response. This caused odd behaviors when clients asked for
 different sets of model types. This in turn resulted in tests failing
 when they never agreed on some progress marker's version that wasn't
 actually being actively updated.

 This change separates all model types version/progress markers in the
 fake server code. This should help clients that are being enabled
 mid-test to get match progress markers when priority and non-priority
 types are requested across separate GetUpdates messages.

 Also removed some special case logic around filtering deleted items. It
 is unclear what purpose that logic was serving."

BUG=651415
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2910993002
Cr-Commit-Position: refs/heads/master@{#475859}
Committed: https://chromium.googlesource.com/chromium/src/+/092f21a0129935b175abf418e957e3b644bc23d3

[pastarmovj, 2017-05-29 13:26:20]

The CQ bit was checked by pastarmovj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 13:26:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pastarmovj, 2017-05-29 13:28:14]

pastarmovj@chromium.org changed reviewers:
+ skym@chromium.org

[pastarmovj, 2017-05-29 13:28:14]

Hi,

please review this CL which pulls your improved impl from the FakeServer class
into the LoopbackServer file. 

This is the first CL from the transition to unifying FakeServer and
LoopbackServer.

The whole thing is in more or less stable form here 
https://codereview.chromium.org/2887343002

Thanks,
Julian

[commit-bot: I haz the power, 2017-05-29 14:28:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 14:28:19]

Dry run: This issue passed the CQ dry run.

[skym, 2017-05-30 15:56:58]

lgtm, but, you should probably add a unit tests as part of this CL, since real
users hit this code.

And on an similar topic, but unrelated to this CL, are there integ tests that
use the local sync configuration stuff?

[pastarmovj, 2017-05-31 08:48:38]

On 2017/05/30 15:56:58, skym wrote:
> lgtm, but, you should probably add a unit tests as part of this CL, since real
> users hit this code.
> 
> And on an similar topic, but unrelated to this CL, are there integ tests that
> use the local sync configuration stuff?

I believe the sync integration tests which are going to hit this code once my
next CL lands are covering it very well. Actually the reason I noticed this code
has changed was because the old code did not satisfy all tests :)


There are also tests that verify Chrome starts in local sync mode and also unit
tests that verify the LoopbackServer is capable of handling requests correctly.
Once it is the backend for the FakeServer it will be even more extensively
covered by all sync integration tests which is why I am looking forward for this
change.

[pastarmovj, 2017-05-31 08:51:17]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2017-05-31 08:51:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 09:52:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496220677923820, "parent_rev":
"a5bcd498a3e82096a38bf3ebe667ce98a8c3d8f7", "commit_rev":
"092f21a0129935b175abf418e957e3b644bc23d3"}

[commit-bot: I haz the power, 2017-05-31 09:52:23]

Description was changed from

==========
[sync] Pull the Sieve implementation from FakeServer to LoopbackServer.

This is a clone of https://codereview.chromium.org/2564663003 in
preparation for replacing the FakeServer impl with the LoopbackServer.
It should also improve the loopack server main purpose.

Original description of the clonned CL:
"Fake server now updates each model type's progress markers independently.

 Previously the fake server used to update all of the progress markers
 to the highest single version of an entity being returned in a
 GetUpdates response. This caused odd behaviors when clients asked for
 different sets of model types. This in turn resulted in tests failing
 when they never agreed on some progress marker's version that wasn't
 actually being actively updated.

 This change separates all model types version/progress markers in the
 fake server code. This should help clients that are being enabled
 mid-test to get match progress markers when priority and non-priority
 types are requested across separate GetUpdates messages.

 Also removed some special case logic around filtering deleted items. It
 is unclear what purpose that logic was serving."

BUG=651415
TEST=components_unittests, browser_tests
==========

to

==========
[sync] Pull the Sieve implementation from FakeServer to LoopbackServer.

This is a clone of https://codereview.chromium.org/2564663003 in
preparation for replacing the FakeServer impl with the LoopbackServer.
It should also improve the loopack server main purpose.

Original description of the clonned CL:
"Fake server now updates each model type's progress markers independently.

 Previously the fake server used to update all of the progress markers
 to the highest single version of an entity being returned in a
 GetUpdates response. This caused odd behaviors when clients asked for
 different sets of model types. This in turn resulted in tests failing
 when they never agreed on some progress marker's version that wasn't
 actually being actively updated.

 This change separates all model types version/progress markers in the
 fake server code. This should help clients that are being enabled
 mid-test to get match progress markers when priority and non-priority
 types are requested across separate GetUpdates messages.

 Also removed some special case logic around filtering deleted items. It
 is unclear what purpose that logic was serving."

BUG=651415
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2910993002
Cr-Commit-Position: refs/heads/master@{#475859}
Committed:
https://chromium.googlesource.com/chromium/src/+/092f21a0129935b175abf418e957...
==========

[commit-bot: I haz the power, 2017-05-31 09:52:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/092f21a0129935b175abf418e957...