Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2887343002: wip 3 (Closed)

Created:
3 years, 7 months ago by pastarmovj
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sync-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

wip 3 wip 2 wip 1 BUG=

Patch Set 1 #

Patch Set 2 : wip 4 #

Patch Set 3 : wip5. #

Patch Set 4 : wip 5 #

Patch Set 5 : wip 6 #

Patch Set 6 : wip 7 #

Patch Set 7 : wip 8 #

Patch Set 8 : wip 9. #

Patch Set 9 : wip 9. #

Patch Set 10 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -1567 lines) Patch
M chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/BUILD.gn View 1 1 chunk +0 lines, -10 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.h View 5 chunks +50 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.cc View 1 2 3 4 5 6 7 8 9 9 chunks +134 lines, -78 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_tombstone_entity.h View 2 chunks +9 lines, -1 line 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_tombstone_entity.cc View 1 2 3 4 5 6 7 8 9 2 chunks +18 lines, -3 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h View 1 chunk +6 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc View 1 2 3 4 5 6 7 8 9 2 chunks +15 lines, -0 lines 0 comments Download
M components/sync/test/fake_server/android/fake_server_helper_android.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/fake_server/android/fake_server_helper_android.cc View 1 2 3 4 5 6 7 8 9 6 chunks +8 lines, -14 lines 0 comments Download
M components/sync/test/fake_server/bookmark_entity.h View 1 1 chunk +0 lines, -75 lines 0 comments Download
M components/sync/test/fake_server/bookmark_entity.cc View 1 1 chunk +0 lines, -119 lines 0 comments Download
M components/sync/test/fake_server/bookmark_entity_builder.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M components/sync/test/fake_server/bookmark_entity_builder.cc View 1 2 3 4 5 6 7 8 9 5 chunks +15 lines, -12 lines 0 comments Download
M components/sync/test/fake_server/fake_server.h View 1 2 3 4 5 6 7 8 9 7 chunks +16 lines, -79 lines 0 comments Download
M components/sync/test/fake_server/fake_server.cc View 1 2 3 4 5 6 7 8 9 6 chunks +41 lines, -492 lines 0 comments Download
M components/sync/test/fake_server/fake_server_entity.h View 1 1 chunk +0 lines, -91 lines 0 comments Download
M components/sync/test/fake_server/fake_server_entity.cc View 1 1 chunk +0 lines, -130 lines 0 comments Download
M components/sync/test/fake_server/permanent_entity.h View 1 1 chunk +0 lines, -63 lines 0 comments Download
M components/sync/test/fake_server/permanent_entity.cc View 1 1 chunk +0 lines, -105 lines 0 comments Download
M components/sync/test/fake_server/tombstone_entity.h View 1 1 chunk +0 lines, -41 lines 0 comments Download
M components/sync/test/fake_server/tombstone_entity.cc View 1 1 chunk +0 lines, -49 lines 0 comments Download
M components/sync/test/fake_server/unique_client_entity.h View 1 1 chunk +0 lines, -68 lines 0 comments Download
M components/sync/test/fake_server/unique_client_entity.cc View 1 1 chunk +0 lines, -102 lines 0 comments Download
M ios/chrome/test/app/sync_test_util.mm View 1 2 3 4 5 6 7 8 9 5 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (16 generated)
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-19 12:47:35 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887343002/40001
3 years, 7 months ago (2017-05-19 12:47:56 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-19 12:56:30 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/442345)
3 years, 7 months ago (2017-05-19 12:56:31 UTC) #4
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-24 14:02:50 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887343002/60001
3 years, 7 months ago (2017-05-24 14:03:15 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-24 14:10:13 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/446137)
3 years, 7 months ago (2017-05-24 14:10:14 UTC) #8
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-26 14:16:32 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887343002/100001
3 years, 7 months ago (2017-05-26 14:16:47 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-26 14:24:24 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/448666)
3 years, 7 months ago (2017-05-26 14:24:25 UTC) #12
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-29 11:51:12 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887343002/160001
3 years, 6 months ago (2017-05-29 11:51:23 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-05-29 11:58:11 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 11:58:12 UTC) #16 
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698