Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2910933002: [heap] Disable concurrent marking for cctests that rely on manual GC. (Closed)

Created:
3 years, 6 months ago by ulan
Modified:
3 years, 6 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Disable concurrent marking for cctests that rely on manual GC. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2910933002 Cr-Commit-Position: refs/heads/master@{#45570} Committed: https://chromium.googlesource.com/v8/v8/+/bc32a0a78fb9c125d8e3dc6e770b3f1aad69a31f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-compaction.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 7 chunks +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
ulan
ptal
3 years, 6 months ago (2017-05-29 07:35:04 UTC) #2
Michael Lippautz
LGTM are these the same tests that also disable stress incremental marking? If yes, should ...
3 years, 6 months ago (2017-05-29 07:42:14 UTC) #3
Michael Lippautz
LGTM are these the same tests that also disable stress incremental marking? If yes, should ...
3 years, 6 months ago (2017-05-29 07:42:15 UTC) #4
ulan
On 2017/05/29 07:42:15, Michael Lippautz wrote: > LGTM > > are these the same tests ...
3 years, 6 months ago (2017-05-29 07:46:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910933002/1
3 years, 6 months ago (2017-05-29 13:59:13 UTC) #7
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 6 months ago (2017-05-29 14:43:15 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 14:43:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bc32a0a78fb9c125d8e3dc6e770b3f1aad6...

Powered by Google App Engine
This is Rietveld 408576698