Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2900603004: [heap] Add --stress-incremental-marking flag. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), Michael Hablich
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add --stress-incremental-marking flag. BUG= Review-Url: https://codereview.chromium.org/2900603004 Cr-Commit-Position: refs/heads/master@{#45553} Committed: https://chromium.googlesource.com/v8/v8/+/75e679113b4a6958be1b3db8d6e01e3b15da394a

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : rebase #

Patch Set 4 : fix test #

Patch Set 5 : fix test #

Patch Set 6 : default flag value #

Patch Set 7 : rebase #

Total comments: 2

Patch Set 8 : remove comment #

Patch Set 9 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -154 lines) Patch
M src/flag-definitions.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 7 1 chunk +9 lines, -3 lines 0 comments Download
M test/cctest/heap/test-array-buffer-tracker.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-compaction.cc View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 72 chunks +192 lines, -149 lines 0 comments Download
M test/cctest/heap/test-incremental-marking.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-strings.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 2 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
ulan
ptal
3 years, 7 months ago (2017-05-23 08:59:43 UTC) #8
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/2900603004/diff/120001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/2900603004/diff/120001/src/heap/heap.cc#newcode5553 src/heap/heap.cc:5553: // start marking immediately. This is unrelated of ...
3 years, 6 months ago (2017-05-29 08:46:21 UTC) #11
ulan
https://codereview.chromium.org/2900603004/diff/120001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/2900603004/diff/120001/src/heap/heap.cc#newcode5553 src/heap/heap.cc:5553: // start marking immediately. On 2017/05/29 08:46:21, Hannes Payer ...
3 years, 6 months ago (2017-05-29 09:06:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900603004/140001
3 years, 6 months ago (2017-05-29 09:06:15 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/22894) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 6 months ago (2017-05-29 10:02:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900603004/160001
3 years, 6 months ago (2017-05-29 10:34:48 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 11:06:23 UTC) #23
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/75e679113b4a6958be1b3db8d6e01e3b15d...

Powered by Google App Engine
This is Rietveld 408576698