Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2910793002: Remove obsolete TODO. (Closed)

Created:
3 years, 6 months ago by nasko
Modified:
3 years, 6 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete TODO. Per the analysis in https://crbug.com/725689, the equivalent functionality of ShouldServiceRequest is present with PlzNavigate, which means this comment is now obsolete. BUG=725689 Review-Url: https://codereview.chromium.org/2910793002 Cr-Commit-Position: refs/heads/master@{#475791} Committed: https://chromium.googlesource.com/chromium/src/+/75468897121e52f03da374623d39993400f1e566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nasko
Hey Charlie, This should now be an obsolete TODO. Very low priority on this. Thanks ...
3 years, 6 months ago (2017-05-26 23:09:01 UTC) #2
Charlie Reis
Thanks, LGTM.
3 years, 6 months ago (2017-05-30 22:53:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910793002/1
3 years, 6 months ago (2017-05-31 03:10:31 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 04:12:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75468897121e52f03da374623d39...

Powered by Google App Engine
This is Rietveld 408576698