Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 2910793002: Remove obsolete TODO. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // See http://dev.chromium.org/developers/design-documents/multi-process-resourc e-loading 5 // See http://dev.chromium.org/developers/design-documents/multi-process-resourc e-loading
6 6
7 #include "content/browser/loader/resource_dispatcher_host_impl.h" 7 #include "content/browser/loader/resource_dispatcher_host_impl.h"
8 8
9 #include <stddef.h> 9 #include <stddef.h>
10 10
(...skipping 1982 matching lines...) Expand 10 before | Expand all | Expand 10 after
1993 bool is_external_protocol = 1993 bool is_external_protocol =
1994 info.common_params.url.is_valid() && 1994 info.common_params.url.is_valid() &&
1995 !resource_context->GetRequestContext()->job_factory()->IsHandledProtocol( 1995 !resource_context->GetRequestContext()->job_factory()->IsHandledProtocol(
1996 info.common_params.url.scheme()); 1996 info.common_params.url.scheme());
1997 bool non_web_url_in_guest = 1997 bool non_web_url_in_guest =
1998 info.is_for_guests_only && 1998 info.is_for_guests_only &&
1999 !policy->IsWebSafeScheme(info.common_params.url.scheme()) && 1999 !policy->IsWebSafeScheme(info.common_params.url.scheme()) &&
2000 !is_external_protocol; 2000 !is_external_protocol;
2001 2001
2002 if (is_shutdown_ || non_web_url_in_guest || 2002 if (is_shutdown_ || non_web_url_in_guest ||
2003 // TODO(davidben): Check ShouldServiceRequest here. This is important; it
2004 // needs to be checked relative to the child that /requested/ the
2005 // navigation. It's where file upload checks, etc., come in.
2006 (delegate_ && !delegate_->ShouldBeginRequest( 2003 (delegate_ && !delegate_->ShouldBeginRequest(
2007 info.common_params.method, 2004 info.common_params.method,
2008 info.common_params.url, 2005 info.common_params.url,
2009 resource_type, 2006 resource_type,
2010 resource_context))) { 2007 resource_context))) {
2011 loader->NotifyRequestFailed(false, net::ERR_ABORTED); 2008 loader->NotifyRequestFailed(false, net::ERR_ABORTED);
2012 return; 2009 return;
2013 } 2010 }
2014 2011
2015 int load_flags = info.begin_params.load_flags; 2012 int load_flags = info.begin_params.load_flags;
(...skipping 660 matching lines...) Expand 10 before | Expand all | Expand 10 after
2676 &throttles); 2673 &throttles);
2677 if (!throttles.empty()) { 2674 if (!throttles.empty()) {
2678 handler.reset(new ThrottlingResourceHandler(std::move(handler), request, 2675 handler.reset(new ThrottlingResourceHandler(std::move(handler), request,
2679 std::move(throttles))); 2676 std::move(throttles)));
2680 } 2677 }
2681 } 2678 }
2682 return handler; 2679 return handler;
2683 } 2680 }
2684 2681
2685 } // namespace content 2682 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698