Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2910703002: [Android] Fix sequence of context menu in CCT is incorrect (Closed)

Created:
3 years, 7 months ago by ltian
Modified:
3 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix sequence of context menu in CCT is incorrect The sequence of context menu for CCT is incorrect that "Open in incognito tab" is shown before "Open in new Chrome tab". This is because Chrome appends those items sequentially to the front of item list (like a Stack). To fix the problem, append the items to the front in the opposite direction. BUG=725665 Review-Url: https://codereview.chromium.org/2910703002 Cr-Commit-Position: refs/heads/master@{#475151} Committed: https://chromium.googlesource.com/chromium/src/+/ea289a66e6444098032ce8f5b3c0dc0da1923c25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
ltian
Can you take a look of this CL? Thanks!
3 years, 7 months ago (2017-05-26 18:06:44 UTC) #2
Ted C
lgtm
3 years, 7 months ago (2017-05-26 18:33:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910703002/1
3 years, 7 months ago (2017-05-26 19:18:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/277275) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 7 months ago (2017-05-26 19:26:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910703002/1
3 years, 7 months ago (2017-05-26 21:12:35 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 21:59:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea289a66e6444098032ce8f5b3c0...

Powered by Google App Engine
This is Rietveld 408576698