Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 2910703002: [Android] Fix sequence of context menu in CCT is incorrect (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
index 581a891a225b65126d60d74f92f444ce329271f0..e95e679e72411c7d3bb064e66f7a24dab3ceb7cd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
@@ -372,7 +372,7 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
private static void addValidItemsToFront(List<ContextMenuItem> validItems,
List<? extends ContextMenuItem> allItems, Set<ContextMenuItem> supportedOptions,
Set<ContextMenuItem> disabledOptions) {
- for (int i = 0; i < allItems.size(); i++) {
+ for (int i = allItems.size() - 1; i >= 0; i--) {
ContextMenuItem item = allItems.get(i);
if (supportedOptions.contains(item) && !disabledOptions.contains(item)) {
assert !validItems.contains(item);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698