Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2910673002:
Explicitly settings story names for the battor.steady_state story set. (Closed)
|
Created:
3 years, 7 months ago by ashleymarie1 Modified:
3 years, 6 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionExplicitly settings story names for the battor.steady_state story set.
BUG=chromium:720002
BUG=chromium:728003
Review-Url: https://codereview.chromium.org/2910673002
Cr-Commit-Position: refs/heads/master@{#476668}
Committed: https://chromium.googlesource.com/chromium/src/+/419395f5fe84ee90f49ac0e9099d979e29994c93
Patch Set 1 #Patch Set 2 : Explicitly settings story names for the battor.steady_state story set. #Messages
Total messages: 20 (8 generated)
Description was changed from ========== Explicitly settings story names for the battor.steady_state story set. BUG=chromium:720002 ========== to ========== Explicitly settings story names for the battor.steady_state story set. BUG=chromium:720002 ==========
ashleymarie@chromium.org changed reviewers: + charliea@chromium.org, nednguyen@google.com, rnephew@chromium.org
Hey Charlie, Want to take a look at the names I'm adding for battor.steady_state story set? Thanks!
On 2017/05/31 02:10:18, ashleymarie1 wrote: > Hey Charlie, > Want to take a look at the names I'm adding for battor.steady_state story set? > Thanks! non-owner lgtm
On 2017/05/31 02:55:08, rnephew (Reviews Here) wrote: > On 2017/05/31 02:10:18, ashleymarie1 wrote: > > Hey Charlie, > > Want to take a look at the names I'm adding for battor.steady_state story set? > > Thanks! > > non-owner lgtm This should also be linked to a bug to port the legacy test data to the new names, if we think that is worthwhile. Charlie, what are your feelings on this?
Description was changed from ========== Explicitly settings story names for the battor.steady_state story set. BUG=chromium:720002 ========== to ========== Explicitly settings story names for the battor.steady_state story set. BUG=chromium:720002 BUG=chromium:728003 ==========
On 2017/05/31 03:01:45, rnephew (Reviews Here) wrote: > On 2017/05/31 02:55:08, rnephew (Reviews Here) wrote: > > On 2017/05/31 02:10:18, ashleymarie1 wrote: > > > Hey Charlie, > > > Want to take a look at the names I'm adding for battor.steady_state story > set? > > > Thanks! > > > > non-owner lgtm > > This should also be linked to a bug to port the legacy test data to the new > names, if we think that is worthwhile. Charlie, what are your feelings on this? Linked to bug for data migration 728003
On 2017/05/31 03:22:38, ashleymarie1 wrote: > On 2017/05/31 03:01:45, rnephew (Reviews Here) wrote: > > On 2017/05/31 02:55:08, rnephew (Reviews Here) wrote: > > > On 2017/05/31 02:10:18, ashleymarie1 wrote: > > > > Hey Charlie, > > > > Want to take a look at the names I'm adding for battor.steady_state story > > set? > > > > Thanks! > > > > > > non-owner lgtm > > > > This should also be linked to a bug to port the legacy test data to the new > > names, if we think that is worthwhile. Charlie, what are your feelings on > this? > > Linked to bug for data migration 728003 Charlie: wouldn't we remove this & merge it to power.desktop anytime soon?
On 2017/05/31 10:25:41, nednguyen wrote: > On 2017/05/31 03:22:38, ashleymarie1 wrote: > > On 2017/05/31 03:01:45, rnephew (Reviews Here) wrote: > > > On 2017/05/31 02:55:08, rnephew (Reviews Here) wrote: > > > > On 2017/05/31 02:10:18, ashleymarie1 wrote: > > > > > Hey Charlie, > > > > > Want to take a look at the names I'm adding for battor.steady_state > story > > > set? > > > > > Thanks! > > > > > > > > non-owner lgtm > > > > > > This should also be linked to a bug to port the legacy test data to the new > > > names, if we think that is worthwhile. Charlie, what are your feelings on > > this? > > > > Linked to bug for data migration 728003 > > Charlie: wouldn't we remove this & merge it to power.desktop anytime soon? If this is one of the benchmarks that is being pulled, then I'll change it to use the old names to prevent the need for a migration here
On 2017/05/31 13:55:20, ashleymarie1 wrote: > On 2017/05/31 10:25:41, nednguyen wrote: > > On 2017/05/31 03:22:38, ashleymarie1 wrote: > > > On 2017/05/31 03:01:45, rnephew (Reviews Here) wrote: > > > > On 2017/05/31 02:55:08, rnephew (Reviews Here) wrote: > > > > > On 2017/05/31 02:10:18, ashleymarie1 wrote: > > > > > > Hey Charlie, > > > > > > Want to take a look at the names I'm adding for battor.steady_state > > story > > > > set? > > > > > > Thanks! > > > > > > > > > > non-owner lgtm > > > > > > > > This should also be linked to a bug to port the legacy test data to the > new > > > > names, if we think that is worthwhile. Charlie, what are your feelings on > > > this? > > > > > > Linked to bug for data migration 728003 > > > > Charlie: wouldn't we remove this & merge it to power.desktop anytime soon? > > If this is one of the benchmarks that is being pulled, then I'll change it to > use the old names to prevent the need for a migration here sgtm lgtm
lgtm
On 2017/05/31 16:27:03, charliea wrote: > lgtm After chatting with Charlie offline, it seems that these test cases are going to be refactored soon anyways so there isn't a strong case for changing the names and doing a migration now. So for now, we're gonna utilize the same test name that's currently being used and just set it explicitly (url)
lgtm
The CQ bit was checked by ashleymarie@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, rnephew@chromium.org Link to the patchset: https://codereview.chromium.org/2910673002/#ps20001 (title: "Explicitly settings story names for the battor.steady_state story set.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496412291186400,
"parent_rev": "6666e3d76a0f228dc3631411235c6e20adfdc37a", "commit_rev":
"c374e1abf03a78680f254071a7171b066fcdb2bd"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496412291186400,
"parent_rev": "7862b82808aaa6c06c239bb666c4dcb397b64351", "commit_rev":
"419395f5fe84ee90f49ac0e9099d979e29994c93"}
Message was sent while issue was closed.
Description was changed from ========== Explicitly settings story names for the battor.steady_state story set. BUG=chromium:720002 BUG=chromium:728003 ========== to ========== Explicitly settings story names for the battor.steady_state story set. BUG=chromium:720002 BUG=chromium:728003 Review-Url: https://codereview.chromium.org/2910673002 Cr-Commit-Position: refs/heads/master@{#476668} Committed: https://chromium.googlesource.com/chromium/src/+/419395f5fe84ee90f49ac0e9099d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/419395f5fe84ee90f49ac0e9099d... |
