Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: tools/perf/page_sets/idle_after_loading_stories.py

Issue 2910673002: Explicitly settings story names for the battor.steady_state story set. (Closed)
Patch Set: Explicitly settings story names for the battor.steady_state story set. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry import story 5 from telemetry import story
6 6
7 # Chrome has high idle CPU usage on these sites, even after they have quiesced. 7 # Chrome has high idle CPU usage on these sites, even after they have quiesced.
8 SITES = [ 8 SITES = [
9 # https://bugs.chromium.org/p/chromium/issues/detail?id=505990 9 # https://bugs.chromium.org/p/chromium/issues/detail?id=505990
10 # TODO(charliea): Temporarily disable this site, since it causes tracing to 10 # TODO(charliea): Temporarily disable this site, since it causes tracing to
(...skipping 14 matching lines...) Expand all
25 25
26 # https://bugs.chromium.org/p/chromium/issues/detail?id=505052 26 # https://bugs.chromium.org/p/chromium/issues/detail?id=505052
27 'http://www.indiatimes.com', 27 'http://www.indiatimes.com',
28 28
29 # https://bugs.chromium.org/p/chromium/issues/detail?id=505002 29 # https://bugs.chromium.org/p/chromium/issues/detail?id=505002
30 'http://www.microsoft.com', 30 'http://www.microsoft.com',
31 ] 31 ]
32 32
33 # TODO(rnephew): Move to seperate file and merge with mac_gpu_sites BasePage. 33 # TODO(rnephew): Move to seperate file and merge with mac_gpu_sites BasePage.
34 class _BasePage(page_module.Page): 34 class _BasePage(page_module.Page):
35 def __init__(self, page_set, url, wait_in_seconds): 35 def __init__(self, page_set, url, wait_in_seconds, name):
36 super(_BasePage, self).__init__(url=url, page_set=page_set) 36 super(_BasePage, self).__init__(url=url, page_set=page_set, name=name)
37 self._wait_in_seconds = wait_in_seconds 37 self._wait_in_seconds = wait_in_seconds
38 38
39 def RunPageInteractions(self, action_runner): 39 def RunPageInteractions(self, action_runner):
40 action_runner.Wait(self._wait_in_seconds) 40 action_runner.Wait(self._wait_in_seconds)
41 41
42 42
43 class IdleAfterLoadingStories(story.StorySet): 43 class IdleAfterLoadingStories(story.StorySet):
44 """Historically, Chrome has high CPU usage on these sites after the page has 44 """Historically, Chrome has high CPU usage on these sites after the page has
45 loaded. These user stories let Chrome idle on the page.""" 45 loaded. These user stories let Chrome idle on the page."""
46 46
47 def __init__(self, wait_in_seconds=0): 47 def __init__(self, wait_in_seconds=0):
48 super(IdleAfterLoadingStories, self).__init__( 48 super(IdleAfterLoadingStories, self).__init__(
49 archive_data_file='data/idle_after_loading_stories.json', 49 archive_data_file='data/idle_after_loading_stories.json',
50 cloud_storage_bucket=story.PARTNER_BUCKET) 50 cloud_storage_bucket=story.PARTNER_BUCKET,
51 verify_names=True)
51 52
52 # Chrome has high idle CPU usage on this site, even after its quiesced. 53 # Chrome has high idle CPU usage on this site, even after its quiesced.
53 # https://crbug.com/638365. 54 # https://crbug.com/638365.
54 for url in SITES: 55 for url in SITES:
55 self.AddStory(_BasePage(self, url, wait_in_seconds)) 56 self.AddStory(_BasePage(self, url, wait_in_seconds, url))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698