[Merge to M59] Revert "cros: Do not schedule attempt when behind captive portal with response 200 i…

[Merge to M59] Revert "cros: Do not schedule attempt when behind captive portal with response 200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651, reviewed on: https://codereview.chromium.org/2756643002

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

TBR=stevenjb@chromium.org
BUG=702273, 705813
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.

Review-Url: https://codereview.chromium.org/2910503002
Cr-Original-Commit-Position: refs/heads/master@{#474815}
Review-Url: https://codereview.chromium.org/2910543002 .
Cr-Commit-Position: refs/branch-heads/3071@{#695}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/82d96071a0cafd9bbf00629a1a537550a826e222

[Qiang(Joe) Xu, 2017-05-25 21:48:06]

Description was changed from

==========
[Merge to M59] Revert "cros: Do not schedule attempt when behind captive portal
with response 200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651, reviewed on:
https://codereview.chromium.org/2756643002

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

TBR=stevenjb@chromium.org
BUG=702273, 705813
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.

Review-Url: https://codereview.chromium.org/2910503002
Cr-Commit-Position: refs/heads/master@{#474815}
(cherry picked from commit 6ce76f805592a7be9a1a7ee470cba75eba4d9585)
==========

to

==========
[Merge to M59] Revert "cros: Do not schedule attempt when behind captive portal
with response 200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651, reviewed on:
https://codereview.chromium.org/2756643002

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

TBR=stevenjb@chromium.org
BUG=702273, 705813
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.

Review-Url: https://codereview.chromium.org/2910503002
Cr-Original-Commit-Position: refs/heads/master@{#474815}
Review-Url: https://codereview.chromium.org/2910543002 .
Cr-Commit-Position: refs/branch-heads/3071@{#695}
Cr-Branched-From:
a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed:
https://chromium.googlesource.com/chromium/src/+/82d96071a0cafd9bbf00629a1a53...
==========

[Qiang(Joe) Xu, 2017-05-25 21:48:07]

Committed patchset #1 (id:1) manually as
82d96071a0cafd9bbf00629a1a537550a826e222 (presubmit successful).