Revert "cros: Do not schedule attempt when behind captive portal with response 200 is detected"

Revert "cros: Do not schedule attempt when behind captive portal with response 200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651, reviewed on: https://codereview.chromium.org/2756643002

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

BUG=702273, 705813, 718094
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.

Review-Url: https://codereview.chromium.org/2910503002
Cr-Commit-Position: refs/heads/master@{#474815}
Committed: https://chromium.googlesource.com/chromium/src/+/6ce76f805592a7be9a1a7ee470cba75eba4d9585

[Qiang(Joe) Xu, 2017-05-25 18:58:25]

Description was changed from

==========
Revert "cros: Do not schedule attempt when behind captive portal with response
200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651.

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

BUG=702273, 705813, 718094
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.
==========

to

==========
Revert "cros: Do not schedule attempt when behind captive portal with response
200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651.

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

TBR=stevenjb@chromium.org
BUG=702273, 705813, 718094
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.
==========

[Qiang(Joe) Xu, 2017-05-25 18:59:00]

Description was changed from

==========
Revert "cros: Do not schedule attempt when behind captive portal with response
200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651.

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

TBR=stevenjb@chromium.org
BUG=702273, 705813, 718094
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.
==========

to

==========
Revert "cros: Do not schedule attempt when behind captive portal with response
200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651.

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

BUG=702273, 705813, 718094
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.
==========

[Qiang(Joe) Xu, 2017-05-25 18:59:01]

warx@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-05-25 20:40:36]

On 2017/05/25 18:59:17, Qiang(Joe) Xu wrote:

Please include a link to the review of the commit that is being reverted so that
we can easily compare the changes (same for the followup CL).

Thanks!

[Qiang(Joe) Xu, 2017-05-25 20:42:13]

Description was changed from

==========
Revert "cros: Do not schedule attempt when behind captive portal with response
200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651.

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

BUG=702273, 705813, 718094
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.
==========

to

==========
Revert "cros: Do not schedule attempt when behind captive portal with response
200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651, reviewed on:
https://codereview.chromium.org/2756643002

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

BUG=702273, 705813, 718094
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.
==========

[Qiang(Joe) Xu, 2017-05-25 20:43:19]

On 2017/05/25 20:40:36, stevenjb wrote:
> On 2017/05/25 18:59:17, Qiang(Joe) Xu wrote:
> 
> Please include a link to the review of the commit that is being reverted so
that
> we can easily compare the changes (same for the followup CL).
> 
> Thanks!

done, thanks

[stevenjb, 2017-05-25 21:05:43]

lgtm

[Qiang(Joe) Xu, 2017-05-25 21:07:45]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-05-25 21:08:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 21:41:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495746465624060, "parent_rev":
"6c146620037bf6c1222d5a0255be9a6ef2ce5137", "commit_rev":
"6ce76f805592a7be9a1a7ee470cba75eba4d9585"}

[commit-bot: I haz the power, 2017-05-25 21:41:35]

Description was changed from

==========
Revert "cros: Do not schedule attempt when behind captive portal with response
200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651, reviewed on:
https://codereview.chromium.org/2756643002

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

BUG=702273, 705813, 718094
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.
==========

to

==========
Revert "cros: Do not schedule attempt when behind captive portal with response
200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651, reviewed on:
https://codereview.chromium.org/2756643002

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

BUG=702273, 705813, 718094
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.

Review-Url: https://codereview.chromium.org/2910503002
Cr-Commit-Position: refs/heads/master@{#474815}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ce76f805592a7be9a1a7ee470cb...
==========

[commit-bot: I haz the power, 2017-05-25 21:41:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6ce76f805592a7be9a1a7ee470cb...