Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2910423002:
cros: Add UMA metrics in migration UI to get more information from migration failures. (Closed)
|
Created:
3 years, 6 months ago by fukino Modified:
3 years, 6 months ago CC:
chromium-reviews, asvitkine+watch_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dspaid Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptioncros: Add UMA metrics in migration UI to get more information from migration failures.
To get more information about migration failures from UMA stats, I'd like to add/update following histograms.
1) Cryptohome.MigrationUI.MigrationResult (new)
We'd like to know the migration result, including errors which only Chrome knows (i.e. Chrome failed to mount existing vault)
2) Cryptohome.MigrationUI.RemoveCryptohomeResult (new)
Chrome UI code tries to remove the user's cryptohome when migration fails.
We'd like to know if the removal succeeds, which we don't have information before.
3) Cryptohome.MigrationUI.VisibleScreen (new)
In theory, a screen can be displayed as a flash (especially in shutdown sequence). We'd like to know how many times each screen *actually* gets visible to users. (i.e. displayed at least 1 second.)
4) Cryptohome.MigrationUI.UserChoice (expansion on existing one)
We have recorded click events on "Update" and "Skip" button on the migration UI. We'd like to know about other buttons such as "Restart" on error screen, too.
BUG=726213
TEST=checked chrome://histograms by disabling auto restart after migration.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2910423002
Cr-Commit-Position: refs/heads/master@{#476592}
Committed: https://chromium.googlesource.com/chromium/src/+/4e58ceae8e2e76c9f95b835827b588b4da3810f4
Patch Set 1 #Patch Set 2 : Add Cryptohome.MigrationUI.ShowFailureScreen. #
Total comments: 10
Patch Set 3 : Use histograms instead of user actions. #
Total comments: 4
Patch Set 4 : Address review comments. #Patch Set 5 : Rebase. #
Messages
Total messages: 36 (23 generated)
Description was changed from ========== cros: Add UMA metrics in migration UI to get more information from migration failures. BUG=726213 ========== to ========== cros: Add UMA metrics in migration UI to get more information from migration failures. BUG=726213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by fukino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== cros: Add UMA metrics in migration UI to get more information from migration failures. BUG=726213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add following two histograms and two user actions. <<Histograms>> 1) Cryptohome.MigrationUI.MigrationResult We'd like to know which migration result is notified to Chrome UI from cryptohomed. Inside cryptohomed, a similar stat is recorded, but we'd like to check if the results are consistent in cryptohomed and Chrome. 2) Cryptohome.MigrationUI.RemoveCryptohomeResult Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. <<User actions>> 3) Cryptohome.MigrationUI.RestartClickedOnFailure When the migration fails, failure screen is shown to the user with "Restart" button, which is basically the only option. We'd like to know how many users see the screen and follow the instruction on the screen by recording clicks on the "Restart" button. 4) Cryptohome.MigrationUI.ShowFailureScreen There is a potential race condition where a user sees a flash of error screen when forcing shutdown during migration. We'd like to know how many times the failure screen is actually shown to the user by excluding the flash cases. BUG=726213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add following two histograms and two user actions. <<Histograms>> 1) Cryptohome.MigrationUI.MigrationResult We'd like to know which migration result is notified to Chrome UI from cryptohomed. Inside cryptohomed, a similar stat is recorded, but we'd like to check if the results are consistent in cryptohomed and Chrome. 2) Cryptohome.MigrationUI.RemoveCryptohomeResult Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. <<User actions>> 3) Cryptohome.MigrationUI.RestartClickedOnFailure When the migration fails, failure screen is shown to the user with "Restart" button, which is basically the only option. We'd like to know how many users see the screen and follow the instruction on the screen by recording clicks on the "Restart" button. 4) Cryptohome.MigrationUI.ShowFailureScreen There is a potential race condition where a user sees a flash of error screen when forcing shutdown during migration. We'd like to know how many times the failure screen is actually shown to the user by excluding the flash cases. BUG=726213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add following two histograms and two user actions. <<Histograms>> 1) Cryptohome.MigrationUI.MigrationResult We'd like to know which migration result is notified to Chrome UI from cryptohomed. Inside cryptohomed, a similar stat is recorded, but we'd like to check if the results are consistent in cryptohomed and Chrome. 2) Cryptohome.MigrationUI.RemoveCryptohomeResult Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. <<User actions>> 3) Cryptohome.MigrationUI.RestartClickedOnFailure When the migration fails, failure screen is shown to the user with "Restart" button, which is basically the only option. We'd like to know how many users see the screen and follow the instruction on the screen by recording clicks on the "Restart" button. 4) Cryptohome.MigrationUI.ShowFailureScreen There is a potential race condition where a user sees a flash of error screen when forcing shutdown during migration. We'd like to know how many times the failure screen is actually shown to the user by excluding the flash cases. BUG=726213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add following two histograms and two user actions. <<Histograms>> 1) Cryptohome.MigrationUI.MigrationResult We'd like to know which migration result is notified to Chrome UI from cryptohomed. Inside cryptohomed, a similar stat is recorded, but we'd like to check if the results are consistent in cryptohomed and Chrome. 2) Cryptohome.MigrationUI.RemoveCryptohomeResult Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. <<User actions>> 3) Cryptohome.MigrationUI.RestartClickedOnFailure When the migration fails, failure screen is shown to the user with "Restart" button, which is basically the only option. We'd like to know how many users see the screen and follow the instruction on the screen by recording clicks on the "Restart" button. 4) Cryptohome.MigrationUI.ShowFailureScreen There is a potential race condition where a user sees a flash of error screen when forcing shutdown during migration. We'd like to know how many times the failure screen is actually shown to the user by excluding the flash cases. BUG=726213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add following two histograms and two user actions. <<Histograms>> 1) Cryptohome.MigrationUI.MigrationResult We'd like to know which migration result is notified to Chrome UI from cryptohomed. Inside cryptohomed, a similar stat is recorded, but we'd like to check if the results are consistent in cryptohomed and Chrome. 2) Cryptohome.MigrationUI.RemoveCryptohomeResult Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. <<User actions>> 3) Cryptohome.MigrationUI.RestartClickedOnFailure When the migration fails, failure screen is shown to the user with "Restart" button, which is basically the only option. We'd like to know how many users see the screen and follow the instruction on the screen by recording clicks on the "Restart" button. 4) Cryptohome.MigrationUI.ShowFailureScreen There is a potential race condition where a user sees a flash of error screen when forcing shutdown during migration. We'd like to know how many times the failure screen is actually shown to the user by excluding the flash cases. BUG=726213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add following two histograms and two user actions. <<Histograms>> 1) Cryptohome.MigrationUI.MigrationResult We'd like to know which migration result is notified to Chrome UI from cryptohomed. Inside cryptohomed, a similar stat is recorded, but we'd like to check if the results are consistent in cryptohomed and Chrome. 2) Cryptohome.MigrationUI.RemoveCryptohomeResult Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. <<User actions>> 3) Cryptohome.MigrationUI.RestartClickedOnFailure When the migration fails, failure screen is shown to the user with "Restart" button, which is basically the only option. We'd like to know how many users see the screen and follow the instruction on the screen by recording clicks on the "Restart" button. 4) Cryptohome.MigrationUI.ShowFailureScreen There is a potential race condition where a user sees a flash of error screen when forcing shutdown during migration. We'd like to know how many times the failure screen is actually shown to the user by excluding the flash cases. BUG=726213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add following two histograms and two user actions. <<Histograms>> 1) Cryptohome.MigrationUI.MigrationResult We'd like to know which migration result is notified to Chrome UI from cryptohomed. Inside cryptohomed, a similar stat is recorded, but we'd like to check if the results are consistent in cryptohomed and Chrome. 2) Cryptohome.MigrationUI.RemoveCryptohomeResult Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. <<User actions>> 3) Cryptohome.MigrationUI.RestartClickedOnFailure When the migration fails, failure screen is shown to the user with "Restart" button, which is basically the only option. We'd like to know how many users see the screen and follow the instruction on the screen by recording clicks on the "Restart" button. 4) Cryptohome.MigrationUI.ShowFailureScreen There is a potential race condition where a user sees a flash of error screen when forcing shutdown during migration. We'd like to know how many times the failure screen is actually shown to the user by excluding the flash cases. This is similar to 3), but this includes the cases when the user shut down the device using power button, leave the device until the battery is 0%, etc... BUG=726213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
fukino@chromium.org changed reviewers: + isherman@chromium.org
isherman@, could you take a look at histograms/ and how the new histograms are recorded? https://codereview.chromium.org/2910423002/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc (right): https://codereview.chromium.org/2910423002/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:87: enum class MigrationResult { MigrationResult and RemoveCryptohomeResult have the same set of potential results. However, this may differ when we get more information about the result of each operation, so I prepared enums separately. https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/actions/a... File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/actions/a... tools/metrics/actions/actions.xml:3731: <action name="Cryptohome.MigrationUI.ShowFailureScreen"> Based on "Generally, Do Not Emit Impressions" section in https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/actio..., I thought it was OK (not good, though) as it is attention-grabbing. Do I understand correctly? (Is there a better option?)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dspaid@chromium.org
The CQ bit was unchecked by dspaid@chromium.org
Metrics LGTM https://codereview.chromium.org/2910423002/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc (right): https://codereview.chromium.org/2910423002/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:131: static_cast<int>(MigrationResult::COUNT)); nit: static_casts shouldn't be needed anymore when using enum classes with UMA_HISTOGRAM_ENUMERATION macros. https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/actions/a... File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/actions/a... tools/metrics/actions/actions.xml:3724: <action name="Cryptohome.MigrationUI.RestartClickedOnFailure"> If you're just interested in understanding how often users click to restart after seeing a failure screen, I'd recommend using an enumerated histogram. OTOH, if you want to analyze sequences of user actions that include this event, then user actions seem reasonable. https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/actions/a... tools/metrics/actions/actions.xml:3731: <action name="Cryptohome.MigrationUI.ShowFailureScreen"> Optional nit: I'd write "Showed" instead of "Show". https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/enums.xml (right): https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/enums.xml:23700: + Incognito mode"/> Hmm, I'm guessing this is a presubmit formatting correction? I'm wondering how/why the code originally landed with the wrong formatting... are we not running the presubmit at the right time? (Not something you need to address in this CL, but if you happen to have a spare moment to investigate, I'd appreciate it!)
Thank! Updated this CL to use histograms instead of user actions for all metrics. https://codereview.chromium.org/2910423002/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc (right): https://codereview.chromium.org/2910423002/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:131: static_cast<int>(MigrationResult::COUNT)); On 2017/05/31 23:34:44, Ilya Sherman wrote: > nit: static_casts shouldn't be needed anymore when using enum classes with > UMA_HISTOGRAM_ENUMERATION macros. Done. https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/actions/a... File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/actions/a... tools/metrics/actions/actions.xml:3724: <action name="Cryptohome.MigrationUI.RestartClickedOnFailure"> On 2017/05/31 23:34:44, Ilya Sherman wrote: > If you're just interested in understanding how often users click to restart > after seeing a failure screen, I'd recommend using an enumerated histogram. > OTOH, if you want to analyze sequences of user actions that include this event, > then user actions seem reasonable. We are not going to analyze sequences for both Cryptohome.MigrationUI.RestartClickedOnFailure and Cryptohome.MigrationUI.ShowFailureScreen. It seems I don't need to add user actions in this CL. I updated the CL as follows: * Cryptohome.MigrationUI.RestartClickedOnFailure I merged this event to Cryptohome.MigrationUI.UserChoice histogram. They enums for UserChoice correspond to click events on buttons, so we can naturally add this event ("Restart" clicked on failure screen) to UserChoice events. * Cryptohome.MigrationUI.ShowFailureScreen I added a new Cryptohome.MigrationUI.VisibleScreen histogram, make it more general. I record every visible screen (i.e. screen which is shown at least 1 second), and it is not limited to the failure screen. https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/enums.xml (right): https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/enums.xml:23700: + Incognito mode"/> On 2017/05/31 23:34:45, Ilya Sherman wrote: > Hmm, I'm guessing this is a presubmit formatting correction? I'm wondering > how/why the code originally landed with the wrong formatting... are we not > running the presubmit at the right time? (Not something you need to address in > this CL, but if you happen to have a spare moment to investigate, I'd appreciate > it!) Yes, I was asked to run "git cl format ." on git cl upload, and got this change. I'm still not sure how the original code lands. The line in question lands in https://codereview.chromium.org/2907153006. In the presubmit log, I can see ** Presubmit Warnings ** The src directory requires source formatting. Please run git cl format . But the presubmit passed. (Maybe it's just warning and WAI?) https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux...
Description was changed from ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add following two histograms and two user actions. <<Histograms>> 1) Cryptohome.MigrationUI.MigrationResult We'd like to know which migration result is notified to Chrome UI from cryptohomed. Inside cryptohomed, a similar stat is recorded, but we'd like to check if the results are consistent in cryptohomed and Chrome. 2) Cryptohome.MigrationUI.RemoveCryptohomeResult Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. <<User actions>> 3) Cryptohome.MigrationUI.RestartClickedOnFailure When the migration fails, failure screen is shown to the user with "Restart" button, which is basically the only option. We'd like to know how many users see the screen and follow the instruction on the screen by recording clicks on the "Restart" button. 4) Cryptohome.MigrationUI.ShowFailureScreen There is a potential race condition where a user sees a flash of error screen when forcing shutdown during migration. We'd like to know how many times the failure screen is actually shown to the user by excluding the flash cases. This is similar to 3), but this includes the cases when the user shut down the device using power button, leave the device until the battery is 0%, etc... BUG=726213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add/update following histograms. 1) Cryptohome.MigrationUI.MigrationResult (new) We'd like to know the migration result, including errors which only Chrome knows (i.e. Chrome failed to mount existing vault) 2) Cryptohome.MigrationUI.RemoveCryptohomeResult (new) Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. 3) Cryptohome.MigrationUI.VisibleScreen (new) In theory, a screen can be displayed as a flash (especially in shutdown sequence). We'd like to know how many times each screen *actually* gets visible to users. (i.e. displayed at least 1 second.) 4) Cryptohome.MigrationUI.UserChoice (expansion on existing one) We have recorded click events on "Update" and "Skip" button on the migration UI. We'd like to know about other buttons such as "Restart" on error screen, too. BUG=726213 TEST=checked chrome://histograms by disabling auto restart after migration. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
fukino@chromium.org changed reviewers: + xiyuan@chromium.org
isherman@, PTAL at histograms, as I made non-trivial changes. xiyuan@, PTAL at others. dspaid@, Please let me know if I miss any metrics you want to look into. Thanks!
lgtm https://codereview.chromium.org/2910423002/diff/40001/chrome/browser/resource... File chrome/browser/resources/chromeos/login/encryption_migration.html (right): https://codereview.chromium.org/2910423002/diff/40001/chrome/browser/resource... chrome/browser/resources/chromeos/login/encryption_migration.html:120: <oobe-text-button inverse on-tap="onRestart_"> nit: onRestart_ -> onRestartOnLowStorage_ similar to onRestartOnFailure_. And update all names along the way until the C++ handler. i.e. method name: onRestart_ -> onRestartOnLowStorage_ event name: 'restart' -> 'restart-on-low-storage' chrome.send message: 'requestRestart' -> 'requestRestartOnLowStorage' c++ handler HandleRequestRestart -> HandleRequestRestartOnLowStorage This would make it easier to follow the code.
Metrics still LGTM (with a nit) https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/enums.xml (right): https://codereview.chromium.org/2910423002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/enums.xml:23700: + Incognito mode"/> On 2017/06/01 09:28:38, fukino wrote: > On 2017/05/31 23:34:45, Ilya Sherman wrote: > > Hmm, I'm guessing this is a presubmit formatting correction? I'm wondering > > how/why the code originally landed with the wrong formatting... are we not > > running the presubmit at the right time? (Not something you need to address > in > > this CL, but if you happen to have a spare moment to investigate, I'd > appreciate > > it!) > > Yes, I was asked to run "git cl format ." on git cl upload, and got this change. > I'm still not sure how the original code lands. > > The line in question lands in https://codereview.chromium.org/2907153006. > In the presubmit log, I can see > ** Presubmit Warnings ** > The src directory requires source formatting. Please run git cl format . > But the presubmit passed. (Maybe it's just warning and WAI?) > > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux... Thanks for investigating that! I think this should probably be surfaced as an error rather than a warning, so as to block the CQ on errors. I filed a bug: https://bugs.chromium.org/p/chromium/issues/detail?id=728872 https://codereview.chromium.org/2910423002/diff/40001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2910423002/diff/40001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:9825: + How many times each screen in migration UI gets visible to the user. A nit: s/gets visible/is shown
Thank you for the reviews! https://codereview.chromium.org/2910423002/diff/40001/chrome/browser/resource... File chrome/browser/resources/chromeos/login/encryption_migration.html (right): https://codereview.chromium.org/2910423002/diff/40001/chrome/browser/resource... chrome/browser/resources/chromeos/login/encryption_migration.html:120: <oobe-text-button inverse on-tap="onRestart_"> On 2017/06/01 15:27:16, xiyuan wrote: > nit: onRestart_ -> onRestartOnLowStorage_ similar to onRestartOnFailure_. And > update all names along the way until the C++ handler. > > i.e. > method name: > onRestart_ -> onRestartOnLowStorage_ > event name: > 'restart' -> 'restart-on-low-storage' > chrome.send message: > 'requestRestart' -> 'requestRestartOnLowStorage' > c++ handler > HandleRequestRestart -> HandleRequestRestartOnLowStorage > > This would make it easier to follow the code. Done I'm sorry I was too lazy...! https://codereview.chromium.org/2910423002/diff/40001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2910423002/diff/40001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:9825: + How many times each screen in migration UI gets visible to the user. A On 2017/06/02 00:04:33, Ilya Sherman wrote: > nit: s/gets visible/is shown Done.
The CQ bit was checked by fukino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/2910423002/#ps60001 (title: "Address review comments.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by fukino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/2910423002/#ps80001 (title: "Rebase.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by fukino@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496383961236350,
"parent_rev": "93f3ac86c1b59b4d5c71c96adb79aa2dc5de0ca4", "commit_rev":
"4e58ceae8e2e76c9f95b835827b588b4da3810f4"}
Message was sent while issue was closed.
Description was changed from ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add/update following histograms. 1) Cryptohome.MigrationUI.MigrationResult (new) We'd like to know the migration result, including errors which only Chrome knows (i.e. Chrome failed to mount existing vault) 2) Cryptohome.MigrationUI.RemoveCryptohomeResult (new) Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. 3) Cryptohome.MigrationUI.VisibleScreen (new) In theory, a screen can be displayed as a flash (especially in shutdown sequence). We'd like to know how many times each screen *actually* gets visible to users. (i.e. displayed at least 1 second.) 4) Cryptohome.MigrationUI.UserChoice (expansion on existing one) We have recorded click events on "Update" and "Skip" button on the migration UI. We'd like to know about other buttons such as "Restart" on error screen, too. BUG=726213 TEST=checked chrome://histograms by disabling auto restart after migration. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== cros: Add UMA metrics in migration UI to get more information from migration failures. To get more information about migration failures from UMA stats, I'd like to add/update following histograms. 1) Cryptohome.MigrationUI.MigrationResult (new) We'd like to know the migration result, including errors which only Chrome knows (i.e. Chrome failed to mount existing vault) 2) Cryptohome.MigrationUI.RemoveCryptohomeResult (new) Chrome UI code tries to remove the user's cryptohome when migration fails. We'd like to know if the removal succeeds, which we don't have information before. 3) Cryptohome.MigrationUI.VisibleScreen (new) In theory, a screen can be displayed as a flash (especially in shutdown sequence). We'd like to know how many times each screen *actually* gets visible to users. (i.e. displayed at least 1 second.) 4) Cryptohome.MigrationUI.UserChoice (expansion on existing one) We have recorded click events on "Update" and "Skip" button on the migration UI. We'd like to know about other buttons such as "Restart" on error screen, too. BUG=726213 TEST=checked chrome://histograms by disabling auto restart after migration. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2910423002 Cr-Commit-Position: refs/heads/master@{#476592} Committed: https://chromium.googlesource.com/chromium/src/+/4e58ceae8e2e76c9f95b835827b5... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/4e58ceae8e2e76c9f95b835827b5... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
