Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2910143002: DOMTokenList: Rename add() and remove() with single string argument. (Closed)

Created:
3 years, 6 months ago by tkent
Modified:
3 years, 6 months ago
Reviewers:
kochi, kouhei (in TOK)
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, eric.carlson_apple.com, fs, gasubic, hiroshige+script_chromium.org, jchaffraix+rendering, kochi+script_chromium.org, kouhei+script_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, nessy, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DOMTokenList: Rename add() and remove() with single string argument. add() -> Add() remove() -> Remove() because they are not web-exposed. Also, this CL removes ExceptionState arguments and adds ASSERT_NO_EXCEPTION in the functions. This CL has no behavior changes. BUG=726214 Review-Url: https://codereview.chromium.org/2910143002 Cr-Commit-Position: refs/heads/master@{#476153} Committed: https://chromium.googlesource.com/chromium/src/+/6211d340a0af0393a4cdc8232c990697d6f7f7b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -23 lines) Patch
M third_party/WebKit/Source/core/dom/DOMTokenList.h View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTokenList.cpp View 2 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tkent
kochi@, would you review this please?
3 years, 6 months ago (2017-05-30 08:07:45 UTC) #4
kouhei (in TOK)
lgtm
3 years, 6 months ago (2017-05-30 08:25:39 UTC) #6
kochi
lgtm
3 years, 6 months ago (2017-05-30 09:10:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910143002/1
3 years, 6 months ago (2017-05-31 23:54:49 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 02:10:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6211d340a0af0393a4cdc8232c99...

Powered by Google App Engine
This is Rietveld 408576698