Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: third_party/WebKit/Source/core/dom/DOMTokenList.h

Issue 2910143002: DOMTokenList: Rename add() and remove() with single string argument. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DOMTokenList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/DOMTokenList.h
diff --git a/third_party/WebKit/Source/core/dom/DOMTokenList.h b/third_party/WebKit/Source/core/dom/DOMTokenList.h
index ed19f011737c752706c5c97af9606ca669a95c98..f5eac95a2cffeba7b084d1037ce561d79420aa8e 100644
--- a/third_party/WebKit/Source/core/dom/DOMTokenList.h
+++ b/third_party/WebKit/Source/core/dom/DOMTokenList.h
@@ -52,18 +52,15 @@ class CORE_EXPORT DOMTokenList : public GarbageCollectedFinalized<DOMTokenList>,
unsigned length() const { return tokens_.size(); }
const AtomicString item(unsigned index) const;
-
bool contains(const AtomicString&) const;
void add(const Vector<String>&, ExceptionState&);
- void add(const AtomicString&, ExceptionState&);
void remove(const Vector<String>&, ExceptionState&);
- void remove(const AtomicString&, ExceptionState&);
bool toggle(const AtomicString&, ExceptionState&);
bool toggle(const AtomicString&, bool force, ExceptionState&);
bool supports(const AtomicString&, ExceptionState&);
-
const AtomicString& value() const { return value_; }
void setValue(const AtomicString&);
+ const AtomicString& toString() const { return value(); }
// This function should be called when the associated attribute value was
// updated.
@@ -71,8 +68,9 @@ class CORE_EXPORT DOMTokenList : public GarbageCollectedFinalized<DOMTokenList>,
const AtomicString& new_value);
const SpaceSplitString& Tokens() const { return tokens_; }
-
- const AtomicString& toString() const { return value(); }
+ // Add() and Remove() have DCHECK for syntax of the specified token.
+ void Add(const AtomicString&);
+ void Remove(const AtomicString&);
protected:
DOMTokenList(Element& element, const QualifiedName& attr)
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DOMTokenList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698