[LayoutNG] Handle empty inlines and border edges

[LayoutNG] Handle empty inlines and border edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
4. Some minor fixes found in wpt/css/CSS2 test suites.

#2 was needed because it was working magically in common cases, but #1
broke the magic. Implementing it properly also helps NG paint work.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2910133002
Cr-Commit-Position: refs/heads/master@{#477273}
Committed: https://chromium.googlesource.com/chromium/src/+/d8dad9313c05c4fb241eb1139a3ec864199b5d96

[kojii, 2017-05-30 06:48:10]

Description was changed from

==========
ngempty

ngempty

BUG=
==========

to

==========
ngempty

ngempty

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-31 07:39:34]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 07:39:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 10:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 10:54:29]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-05-31 11:34:17]

Description was changed from

==========
ngempty

ngempty

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Handles empty inlines and edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
4. Some minor fixes found in wpt/css/CSS2 test suites.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-31 11:34:29]

Description was changed from

==========
[LayoutNG] Handles empty inlines and edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
4. Some minor fixes found in wpt/css/CSS2 test suites.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Handle empty inlines and edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
4. Some minor fixes found in wpt/css/CSS2 test suites.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-31 11:35:11]

Description was changed from

==========
[LayoutNG] Handle empty inlines and edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
4. Some minor fixes found in wpt/css/CSS2 test suites.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Handle empty inlines and edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
2. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
3. Add margins/borders/paddings to NGInlineItemResult to re-use in
  later phases.
4. Some minor fixes found in wpt/css/CSS2 test suites.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-31 12:39:31]

Description was changed from

==========
[LayoutNG] Handle empty inlines and edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
2. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
3. Add margins/borders/paddings to NGInlineItemResult to re-use in
  later phases.
4. Some minor fixes found in wpt/css/CSS2 test suites.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Handle empty inlines and edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
4. Some minor fixes found in wpt/css/CSS2 test suites.

#2 was needed because it was working magically in common cases, but #1
broke it. Implementing it properly also helps NG paint work.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-31 12:39:56]

Description was changed from

==========
[LayoutNG] Handle empty inlines and edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
4. Some minor fixes found in wpt/css/CSS2 test suites.

#2 was needed because it was working magically in common cases, but #1
broke it. Implementing it properly also helps NG paint work.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Handle empty inlines and edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
4. Some minor fixes found in wpt/css/CSS2 test suites.

#2 was needed because it was working magically in common cases, but #1
broke the magic. Implementing it properly also helps NG paint work.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-31 15:36:15]

Description was changed from

==========
[LayoutNG] Handle empty inlines and edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
4. Some minor fixes found in wpt/css/CSS2 test suites.

#2 was needed because it was working magically in common cases, but #1
broke the magic. Implementing it properly also helps NG paint work.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Handle empty inlines and border edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
4. Some minor fixes found in wpt/css/CSS2 test suites.

#2 was needed because it was working magically in common cases, but #1
broke the magic. Implementing it properly also helps NG paint work.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-31 15:36:45]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 15:37:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-31 15:39:14]

kojii@chromium.org changed reviewers:
+ eae@chromium.org, ikilpatrick@chromium.org

[kojii, 2017-05-31 15:39:15]

PTAL, given SetBorderEdges CL seems smooth.

# sorry Ian, I'm touching line breaker a bit more.

[eae, 2017-05-31 16:12:10]

https://codereview.chromium.org/2910133002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc
(right):

https://codereview.chromium.org/2910133002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:245:
box.SetBorderEdges(static_cast<NGBorderEdges::Logical>(
We probably don't want to cast a bitfield to an enum.

[eae, 2017-05-31 16:12:43]

https://codereview.chromium.org/2910133002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc
(right):

https://codereview.chromium.org/2910133002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:134:
line_left_position = position + item_result.margins.inline_start;
Can the margin be negative here? If so do we need any special handling for that?

[kojii, 2017-05-31 16:45:52]

Thank you for your prompt review as always. Comments inline, patch not updated.

https://codereview.chromium.org/2910133002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc
(right):

https://codereview.chromium.org/2910133002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:134:
line_left_position = position + item_result.margins.inline_start;
On 2017/05/31 at 16:12:43, eae wrote:
> Can the margin be negative here?

Yes.

> If so do we need any special handling for that?

Saw only a few cases, csswg-test has it, it looks like this (overlapping with
previous boxes) is good.

https://codereview.chromium.org/2910133002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:245:
box.SetBorderEdges(static_cast<NGBorderEdges::Logical>(
On 2017/05/31 at 16:12:09, eae wrote:
> We probably don't want to cast a bitfield to an enum.

When OR-ed (|), C++ casts enum to int, so we need to re-cast to enum...c++
doesn't look do a great job to handle typed bitfields.

Or do I misunderstand your comment? We normally cast bitfield class members to
enum, no? Please elaborate if I seem to misunderstand.

[commit-bot: I haz the power, 2017-05-31 17:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 17:07:02]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[eae, 2017-06-01 20:33:53]

On 2017/05/31 16:45:52, kojii wrote:
> Thank you for your prompt review as always. Comments inline, patch not
updated.
> 
>
https://codereview.chromium.org/2910133002/diff/100001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc
> (right):
> 
>
https://codereview.chromium.org/2910133002/diff/100001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:134:
> line_left_position = position + item_result.margins.inline_start;
> On 2017/05/31 at 16:12:43, eae wrote:
> > Can the margin be negative here?
> 
> Yes.
> 
> > If so do we need any special handling for that?
> 
> Saw only a few cases, csswg-test has it, it looks like this (overlapping with
> previous boxes) is good.
> 
>
https://codereview.chromium.org/2910133002/diff/100001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:245:
> box.SetBorderEdges(static_cast<NGBorderEdges::Logical>(
> On 2017/05/31 at 16:12:09, eae wrote:
> > We probably don't want to cast a bitfield to an enum.
> 
> When OR-ed (|), C++ casts enum to int, so we need to re-cast to enum...c++
> doesn't look do a great job to handle typed bitfields.
> 
> Or do I misunderstand your comment? We normally cast bitfield class members to
> enum, no? Please elaborate if I seem to misunderstand.

The enum defines the different edges not all possible combinations. Say we have
bottom and top, the value of the field would then be 5 (1 | 4). The enum does
not have an entry for the value five so the cast will either fail or we'll end
up with undefined behavior.

We want to cast for enum values but not for bitmasks.

[kojii, 2017-06-02 05:35:54]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 05:36:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-02 05:36:56]

Patchset #7 (id:120001) has been deleted

[kojii, 2017-06-02 05:39:54]

On 2017/06/01 at 20:33:53, eae wrote:
> The enum defines the different edges not all possible combinations. Say we
have bottom and top, the value of the field would then be 5 (1 | 4). The enum
does not have an entry for the value five so the cast will either fail or we'll
end up with undefined behavior.
> 
> We want to cast for enum values but not for bitmasks.

Ooh, thank you, I didn't know it's undefined, then misunderstood bitmasks with
bitfields. Totally makes sense now, fixed to unsigned.

[commit-bot: I haz the power, 2017-06-02 07:26:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 07:26:33]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kojii, 2017-06-02 10:32:53]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 10:33:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-02 10:37:35]

On 2017/06/02 at 05:39:54, kojii wrote:
> 
> Ooh, thank you, I didn't know it's undefined, then misunderstood bitmasks with
bitfields. Totally makes sense now, fixed to unsigned.

Revised again, logical is struct while physical is bitmasks, because I didn't
like the loss of type-safety between physical/logical, and I hope compilers are
smart to make it efficient enough. WDYT?

[kojii, 2017-06-02 10:46:09]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 10:46:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-02 10:53:42]

Patchset #8 (id:160001) has been deleted

[commit-bot: I haz the power, 2017-06-02 12:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 12:28:51]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[eae, 2017-06-05 16:48:41]

LGTM!

[kojii, 2017-06-06 03:09:11]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-06-06 03:09:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 03:12:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 03:12:56]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kojii, 2017-06-06 09:41:40]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 09:41:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 11:54:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 11:54:47]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-06-06 13:18:26]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-06-06 13:18:27]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2910133002/#ps200001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-06 13:18:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 13:25:04]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1496755106890580,
"parent_rev": "d7aa85532ccb65e6dd65bde916bc46ca8b010346", "commit_rev":
"d8dad9313c05c4fb241eb1139a3ec864199b5d96"}

[commit-bot: I haz the power, 2017-06-06 13:25:12]

Description was changed from

==========
[LayoutNG] Handle empty inlines and border edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
4. Some minor fixes found in wpt/css/CSS2 test suites.

#2 was needed because it was working magically in common cases, but #1
broke the magic. Implementing it properly also helps NG paint work.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Handle empty inlines and border edges

After we supported inline margin/border/padding[1] and adding box
fragments when needed[2], this patch adds a few finishing touches:

1. Creates empty box fragments when needed. [2] creates box fragments
   for inline boxes, but does not create when it's empty.
   Whether to create empty box fragments or not affects layout, since
   such inline boxes affects line height. The behavior isn't well
   defined, but there are some CSS2 tests. NG passes them now.
2. Improve "Edges" support. When an inline box was broken by line wrap
   or inline continuation, the broken edge should not have margins/
   borders/paddings. This patch supports suppressing borders on edges.
   Note, computing positions for edges was done in [1].
3. Add margins/borders/paddings to NGInlineItemResult to re-use in
   later phases.
4. Some minor fixes found in wpt/css/CSS2 test suites.

#2 was needed because it was working magically in common cases, but #1
broke the magic. Implementing it properly also helps NG paint work.

[1] https://codereview.chromium.org/2865903002
[2] https://codereview.chromium.org/2898413002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2910133002
Cr-Commit-Position: refs/heads/master@{#477273}
Committed:
https://chromium.googlesource.com/chromium/src/+/d8dad9313c05c4fb241eb1139a3e...
==========

[commit-bot: I haz the power, 2017-06-06 13:25:13]

Committed patchset #9 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/d8dad9313c05c4fb241eb1139a3e...