[LayoutNG] Add box fragments to line boxes when needed

[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow. When box fragments are
needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations don't do so, while they are quite interoperable. This
patch places box fragments to be interoperable with existing
implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the geometry of box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2898413002
Cr-Commit-Position: refs/heads/master@{#475262}
Committed: https://chromium.googlesource.com/chromium/src/+/484bedec5922468b681054f150c28504bdd144e1

[kojii, 2017-05-24 03:21:30]

Description was changed from

==========
WIP: [LayoutNG] Add box fragments in line boxes when needed

BUG=
==========

to

==========
WIP: [LayoutNG] Add box fragments in line boxes when needed

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-26 17:15:43]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 17:16:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 17:25:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 17:25:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kojii, 2017-05-26 17:31:16]

Description was changed from

==========
WIP: [LayoutNG] Add box fragments in line boxes when needed

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow for now, but When box
fragments are needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations are quite interoperable. This patch places box fragments
to be interoperable with existing implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. Inline positioning of box with borders
is incorrect until it lands. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-26 17:36:16]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[kojii, 2017-05-26 17:36:19]

Description was changed from

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow for now, but When box
fragments are needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations are quite interoperable. This patch places box fragments
to be interoperable with existing implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. Inline positioning of box with borders
is incorrect until it lands. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow. When box fragments are
needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations are quite interoperable. This patch places box fragments
to be interoperable with existing implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. Inline positioning of box with borders
is incorrect until it lands. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-26 17:36:32]

Patchset #11 (id:200001) has been deleted

[commit-bot: I haz the power, 2017-05-26 17:36:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-26 17:45:38]

Description was changed from

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow. When box fragments are
needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations are quite interoperable. This patch places box fragments
to be interoperable with existing implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. Inline positioning of box with borders
is incorrect until it lands. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow. When box fragments are
needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations don't do so, while they are quite interoperable. This
patch places box fragments to be interoperable with existing
implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. Inline positioning of box with borders
is incorrect until it lands. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-26 17:46:10]

Description was changed from

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow. When box fragments are
needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations don't do so, while they are quite interoperable. This
patch places box fragments to be interoperable with existing
implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. Inline positioning of box with borders
is incorrect until it lands. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow. When box fragments are
needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations don't do so, while they are quite interoperable. This
patch places box fragments to be interoperable with existing
implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the geometry of box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. Inline positioning of box with borders
is incorrect until it lands. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-26 17:50:28]

kojii@chromium.org changed reviewers:
+ eae@chromium.org, ikilpatrick@chromium.org

[kojii, 2017-05-26 17:50:29]

PTAL.

[kojii, 2017-05-26 17:51:20]

Description was changed from

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow. When box fragments are
needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations don't do so, while they are quite interoperable. This
patch places box fragments to be interoperable with existing
implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the geometry of box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. Inline positioning of box with borders
is incorrect until it lands. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow. When box fragments are
needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations don't do so, while they are quite interoperable. This
patch places box fragments to be interoperable with existing
implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the geometry of box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[eae, 2017-05-26 18:09:46]

Would you mind adding a section to Source/core/layout/ng/README.md explaining
the basics of inline layout in NG and copy over some of your great comments? It
is getting to the point where we really need a high level overview explaining
the basics.
Start with the basics and I'll help you fill it out over time.

https://codereview.chromium.org/2898413002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc
(right):

https://codereview.chromium.org/2898413002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:192: //
|text0|text1|text2|text3|null1|text5|
2 here should be null, right?

https://codereview.chromium.org/2898413002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:193: //
When there is a placeholder [2,4), this loop creates a box fragment with
[2,4] or (2,4)

https://codereview.chromium.org/2898413002/diff/220001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc
(right):

https://codereview.chromium.org/2898413002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc:7:
#include "core/layout/LayoutInline.h"
What do we need LayoutInline for?

[kojii, 2017-05-26 18:22:50]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 18:23:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-26 18:26:22]

Thank you for your prompt review as always.

> Would you mind adding a section to Source/core/layout/ng/README.md explaining
the basics of inline layout in NG and copy over some of your great comments? It
is getting to the point where we really need a high level overview explaining
the basics.
> Start with the basics and I'll help you fill it out over time.

Thank you for asking this, I think I have better confidence on the current
overall design that it's a good time to write it down. I'll raise its priority.

https://codereview.chromium.org/2898413002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc
(right):

https://codereview.chromium.org/2898413002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:192: //
|text0|text1|text2|text3|null1|text5|
On 2017/05/26 at 18:09:46, eae wrote:
> 2 here should be null, right?

"2" is in BoxFragmentPlaceholder but not in the child list. Clarified by
comments in AddBoxFragmentPlaceholder().

https://codereview.chromium.org/2898413002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:193: //
When there is a placeholder [2,4), this loop creates a box fragment with
On 2017/05/26 at 18:09:46, eae wrote:
> [2,4] or (2,4)

Changed to "(end is exclusive)".

https://codereview.chromium.org/2898413002/diff/220001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc
(right):

https://codereview.chromium.org/2898413002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc:7:
#include "core/layout/LayoutInline.h"
On 2017/05/26 at 18:09:46, eae wrote:
> What do we need LayoutInline for?

Removed, this was left over, thank you.

[eae, 2017-05-26 18:30:37]

Thanks!

LGTM

[commit-bot: I haz the power, 2017-05-26 19:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:36:23]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kojii, 2017-05-27 00:39:20]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-05-27 00:39:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 01:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 01:37:16]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kojii, 2017-05-27 13:44:43]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 13:44:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 15:14:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 15:14:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-05-28 12:28:26]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-28 12:28:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-28 12:28:36]

Patchset #13 (id:260001) has been deleted

[commit-bot: I haz the power, 2017-05-28 14:18:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-28 14:18:09]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-05-28 15:45:33]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-05-28 15:45:34]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2898413002/#ps280001
(title: "x64 build fix")

[commit-bot: I haz the power, 2017-05-28 15:45:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-28 15:49:00]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1495986333959890,
"parent_rev": "2ab4d878e867d169a3cae4c1f006955ce0439357", "commit_rev":
"484bedec5922468b681054f150c28504bdd144e1"}

[commit-bot: I haz the power, 2017-05-28 15:49:12]

Description was changed from

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow. When box fragments are
needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations don't do so, while they are quite interoperable. This
patch places box fragments to be interoperable with existing
implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the geometry of box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Add box fragments to line boxes when needed

This patch creates box fragments to line boxes when needed.

This patch creates box fragments when an inline box has background or
box decorations such as border or box shadow. When box fragments are
needed is to be determined with the paint code.

The previous CL[1] placed InlineFlowBox to contain all children. CSS
leaves positioning of inline boxes undefined, but testing indicates that
implementations don't do so, while they are quite interoperable. This
patch places box fragments to be interoperable with existing
implementations.

NGInlineNode::CopyFragmentDataToLayoutBox needed an overhaul to place
InlineFlowBox by using the geometry of box fragments.

This patch also adds a few minor additions:
* Add NGFragment::Offset().
* Add NGFragmentBuilder constructor from LayoutObject.
* Add NGLayoutResult::MutablePhysicalFragment() to allow move semantics.
* Add NGLineBoxFragmentBuilder::WritingMode().

There are some minor two-way dependencies to inline
margin/border/padding patch[2]. This will be cleaned up when it landed.

[1] https://codereview.chromium.org/2887623002
[2] https://codereview.chromium.org/2865903002

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2898413002
Cr-Commit-Position: refs/heads/master@{#475262}
Committed:
https://chromium.googlesource.com/chromium/src/+/484bedec5922468b681054f150c2...
==========

[commit-bot: I haz the power, 2017-05-28 15:49:13]

Committed patchset #13 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/484bedec5922468b681054f150c2...