Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2909763002: Revert of Rename MaximizeMode to TabletMode (Closed)

Created:
3 years, 6 months ago by oshima
Modified:
3 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, aboxhall+watch_chromium.org, blakeo+virtualkb_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, davemoore+watch_chromium.org, dcheng, derat+watch_chromium.org, dfaden+virtualkb_google.com, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, groby+virtualkb_chromium.org, hidehiko+watch_chromium.org, jam, je_julie, kalyank, lhchavez+watch_chromium.org, mlamouri+watch-screen-orientation_chromium.org, nektar+watch_chromium.org, oka+watchvk_chromium.org, oshima+watch_chromium.org, qsr+mojo_chromium.org, sadrul, tfarina, victorhsieh+watch_chromium.org, viettrungluu+watch_chromium.org, yhanada+watchvk_chromium.org, yusukes+watch_chromium.org, yuzo+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rename MaximizeMode to TabletMode (patchset #3 id:80001 of https://codereview.chromium.org/2906803002/ ) Reason for revert: Failed to be landed before branch cut. I'll try again before 61 cut. Original issue's description: > Rename MaximizeMode to TabletMode > > renamed > * maximize_mode_xxx files to tablet_mode_xxx > * Class name MaximizeModeXxx to TabletModeXxx > * variable names maximize_mode(xxx) to tablet_mode(xxx) > * comments "maximize mode" to "tablet mode" > > BUG=726476 > R=skuhne@chromium.org, sky@chromium.org, reveman@chromium.org > TEST=None > > Review-Url: https://codereview.chromium.org/2906803002 > Cr-Commit-Position: refs/heads/master@{#474940} > Committed: https://chromium.googlesource.com/chromium/src/+/0827cd5289824410906172f4852f5f7e308d505c TBR=reveman@chromium.org,skuhne@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=726476 Review-Url: https://codereview.chromium.org/2909763002 Cr-Commit-Position: refs/heads/master@{#475187} Committed: https://chromium.googlesource.com/chromium/src/+/341337af9e7325e850cedacec0e9da958765dd83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7150 lines, -7081 lines) Patch
M ash/BUILD.gn View 7 chunks +24 lines, -24 lines 0 comments Download
M ash/accelerators/accelerator_controller_delegate_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/accelerators/debug_commands.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/aura/shell_port_classic.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/aura/shell_port_classic.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 18 chunks +27 lines, -26 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 5 chunks +11 lines, -6 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 10 chunks +23 lines, -23 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M ash/frame/custom_frame_view_ash_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M ash/frame/header_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/frame/header_view.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/metrics/pointer_metrics_recorder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/metrics/pointer_metrics_recorder_unittest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M ash/mojo_interface_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/bridge/shell_port_mash.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/bridge/shell_port_mash.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shell.h View 5 chunks +14 lines, -14 lines 0 comments Download
M ash/shell.cc View 5 chunks +19 lines, -19 lines 0 comments Download
M ash/shell_observer.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/shell_port.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/brightness/tray_brightness.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ash/system/brightness/tray_brightness_unittest.cc View 3 chunks +25 lines, -17 lines 0 comments Download
M ash/system/overview/overview_button_tray.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/overview/overview_button_tray.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 7 chunks +33 lines, -22 lines 0 comments Download
M ash/system/power/tablet_power_button_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/power/tablet_power_button_controller.cc View 3 chunks +14 lines, -13 lines 0 comments Download
M ash/system/power/tablet_power_button_controller_unittest.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M ash/system/rotation/tray_rotation_lock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/rotation/tray_rotation_lock.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M ash/system/rotation/tray_rotation_lock_unittest.cc View 6 chunks +49 lines, -35 lines 0 comments Download
M ash/system/screen_layout_observer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/screen_layout_observer_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/test/shell_test_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/virtual_keyboard_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/virtual_keyboard_controller.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 8 chunks +27 lines, -21 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
A ash/wm/maximize_mode/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/accelerometer_test_data_literals.cc View 1 chunk +2028 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_backdrop_delegate_impl.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_backdrop_delegate_impl.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_controller.h View 1 chunk +230 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_controller.cc View 1 chunk +486 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 chunk +671 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_event_handler.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_event_handler.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_event_handler_aura.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_event_handler_aura.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_window_manager.h View 1 chunk +145 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +309 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 chunk +1710 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_window_state.h View 1 chunk +93 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +351 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.cc View 1 chunk +52 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc View 1 chunk +165 lines, -0 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/power_button_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D ash/wm/tablet_mode/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D ash/wm/tablet_mode/accelerometer_test_data_literals.cc View 1 chunk +0 lines, -2028 lines 0 comments Download
D ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard.h View 1 chunk +0 lines, -17 lines 0 comments Download
D ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_ozone.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_ozone.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_x11.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_backdrop_delegate_impl.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_backdrop_delegate_impl.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_controller.h View 1 chunk +0 lines, -230 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_controller.cc View 1 chunk +0 lines, -482 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_controller_unittest.cc View 1 chunk +0 lines, -670 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_event_handler.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_event_handler.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_event_handler_aura.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_event_handler_aura.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_window_manager.h View 1 chunk +0 lines, -145 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_window_manager.cc View 1 chunk +0 lines, -306 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc View 1 chunk +0 lines, -1705 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_window_state.h View 1 chunk +0 lines, -92 lines 0 comments Download
D ash/wm/tablet_mode/tablet_mode_window_state.cc View 1 chunk +0 lines, -350 lines 0 comments Download
M ash/wm/window_positioner.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_positioner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_properties.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/window_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 5 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 5 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 5 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/exo/keyboard.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/exo/keyboard.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M components/exo/shell_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/wayland/server.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M components/exo/wm_helper.h View 5 chunks +12 lines, -12 lines 0 comments Download
M components/exo/wm_helper.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M components/exo/wm_helper_ash.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/exo/wm_helper_ash.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M components/exo/wm_helper_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/wm_helper_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/filters/ash_unittests_mus.filter View 3 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
oshima
Created Revert of Rename MaximizeMode to TabletMode
3 years, 6 months ago (2017-05-26 23:30:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909763002/1
3 years, 6 months ago (2017-05-26 23:30:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/341337af9e7325e850cedacec0e9da958765dd83
3 years, 6 months ago (2017-05-26 23:34:42 UTC) #6
findit-for-me
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2905383003/ by findit-for-me@appspot.gserviceaccount.com. ...
3 years, 6 months ago (2017-05-27 00:00:56 UTC) #7
afakhry
On 2017/05/27 00:00:56, findit-for-me wrote: > A revert of this CL (patchset #1 id:1) has ...
3 years, 6 months ago (2017-05-27 00:28:36 UTC) #8
varkha
3 years, 6 months ago (2017-05-27 00:31:14 UTC) #9
Message was sent while issue was closed.
On 2017/05/27 00:28:36, afakhry wrote:
> On 2017/05/27 00:00:56, findit-for-me wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2905383003/ by
> > mailto:findit-for-me@appspot.gserviceaccount.com.
> > 
> > The reason for reverting is: 
> > Findit (https://goo.gl/kROfz5) identified CL at revision 475187 as the
> > culprit for failures in the build cycles as shown on:
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....
> 
> Oshima-san, this CL seems to have called build failures 
> 
> ../../ash/wm/maximize_mode/maximize_mode_window_state.cc:310:9: error: cannot
> initialize a parameter of type 'aura::Window *' with an rvalue of type
> 'ash::WmWindow *'
>         WmWindow::Get(window_state->window()));
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../ash/wm/screen_pinning_controller.h:40:38: note: passing argument to
> parameter 'pinned_window' here
>   void SetPinnedWindow(aura::Window* pinned_window);

The fix at https://codereview.chromium.org/2913433002/ is now in CQ.

Powered by Google App Engine
This is Rietveld 408576698