Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2909543002: [DMC #19] Remove WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS from TextMatchMarker.h (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS from TextMatchMarker.h This appears to date back to https://codereview.chromium.org/289323003 It does not appear to be necessary anymore. BUG=707867 Review-Url: https://codereview.chromium.org/2909543002 Cr-Commit-Position: refs/heads/master@{#475132} Committed: https://chromium.googlesource.com/chromium/src/+/8b73d36ca42ac01b44b8cda903978a0fe79fdc0e

Patch Set 1 #

Patch Set 2 : Remove dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
rlanday
3 years, 7 months ago (2017-05-25 21:27:58 UTC) #5
Xiaocheng
lgtm
3 years, 7 months ago (2017-05-26 00:47:32 UTC) #8
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-26 04:43:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909543002/20001
3 years, 6 months ago (2017-05-26 18:45:38 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 21:19:41 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8b73d36ca42ac01b44b8cda90397...

Powered by Google App Engine
This is Rietveld 408576698