[DMC #20] Remove DocumentMarker::IsActiveMatch() and SetIsActiveMatch() methods

Remove DocumentMarker::IsActiveMatch() and SetIsActiveMatch() methods

In https://codereview.chromium.org/2904093002 I'm moving the storage for the
MatchStatus flag from a subclass of DocumentMarkerDetails into TextMatchMarker.
This CL follows up by removing the getter/setter methods for this flag from
DocumentMarker, forcing callers to cast to TextMatchMarker. This helps clarify
where callers are making assumptions about the types of certain DocumentMarkers.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2909553002
Cr-Commit-Position: refs/heads/master@{#476142}
Committed: https://chromium.googlesource.com/chromium/src/+/6d7032c3fd7b7311e54b49e267f843ab9196279e

[rlanday, 2017-05-25 21:27:00]

Description was changed from

==========
Remove DocumentMarker::IsActiveMatch() and SetIsActiveMatch() methods

In https://codereview.chromium.org/2904093002 I'm moving the storage for the
MatchStatus flag from a subclass of DocumentMarkerDetails into TextMatchMarker.
This CL follows up by removing the getter/setter methods for this flag from
DocumentMarker, forcing callers to cast to TextMatchMarker. This helps clarify
where callers are making assumptions about the types of certain DocumentMarkers.

BUG=707867
==========

to

==========
Remove DocumentMarker::IsActiveMatch() and SetIsActiveMatch() methods

In https://codereview.chromium.org/2904093002 I'm moving the storage for the
MatchStatus flag from a subclass of DocumentMarkerDetails into TextMatchMarker.
This CL follows up by removing the getter/setter methods for this flag from
DocumentMarker, forcing callers to cast to TextMatchMarker. This helps clarify
where callers are making assumptions about the types of certain DocumentMarkers.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rlanday, 2017-05-25 21:27:07]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-25 21:27:44]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[commit-bot: I haz the power, 2017-05-25 21:27:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-05-26 01:03:00]

I/ve added a comment to TextMatchMarker and removed some info from the comment
on DocumentMarker that no longer belongs there

[yosin_UTC9, 2017-05-26 04:45:50]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-05-26 04:45:50]

lgtm

+tkent@, for core/layout, core/paint and core/testing

[tkent, 2017-05-26 04:52:26]

lgtm

https://codereview.chromium.org/2909553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.h (right):

https://codereview.chromium.org/2909553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.h:25: #include
"core/editing/markers/TextMatchMarker.h"
Is this #include necessary?

[rlanday, 2017-05-26 19:26:41]

On 2017/05/26 at 04:52:26, tkent wrote:
> lgtm
> 
>
https://codereview.chromium.org/2909553002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.h
(right):
> 
>
https://codereview.chromium.org/2909553002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.h:25: #include
"core/editing/markers/TextMatchMarker.h"
> Is this #include necessary?

I've added a forward include and moved it to the .cpp file

[rlanday, 2017-05-26 21:43:02]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 21:43:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 23:29:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 23:29:28]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-05-31 20:25:15]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 20:26:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-05-31 21:20:31]

The CQ bit was unchecked by rlanday@chromium.org

[rlanday, 2017-05-31 21:20:33]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-05-31 21:20:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2909553002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-31 21:21:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 21:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:37:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rlanday, 2017-05-31 22:09:48]

The CQ bit was checked by rlanday@chromium.org

[commit-bot: I haz the power, 2017-05-31 22:10:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 22:22:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 22:22:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rlanday, 2017-06-01 00:01:15]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-01 00:01:15]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2909553002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-01 00:02:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 01:52:06]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496275275278200,
"parent_rev": "b4e5b1d42138414abcef8816f6af08fbebdbccd2", "commit_rev":
"6d7032c3fd7b7311e54b49e267f843ab9196279e"}

[commit-bot: I haz the power, 2017-06-01 01:52:54]

Description was changed from

==========
Remove DocumentMarker::IsActiveMatch() and SetIsActiveMatch() methods

In https://codereview.chromium.org/2904093002 I'm moving the storage for the
MatchStatus flag from a subclass of DocumentMarkerDetails into TextMatchMarker.
This CL follows up by removing the getter/setter methods for this flag from
DocumentMarker, forcing callers to cast to TextMatchMarker. This helps clarify
where callers are making assumptions about the types of certain DocumentMarkers.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove DocumentMarker::IsActiveMatch() and SetIsActiveMatch() methods

In https://codereview.chromium.org/2904093002 I'm moving the storage for the
MatchStatus flag from a subclass of DocumentMarkerDetails into TextMatchMarker.
This CL follows up by removing the getter/setter methods for this flag from
DocumentMarker, forcing callers to cast to TextMatchMarker. This helps clarify
where callers are making assumptions about the types of certain DocumentMarkers.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2909553002
Cr-Commit-Position: refs/heads/master@{#476142}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d7032c3fd7b7311e54b49e267f8...
==========

[commit-bot: I haz the power, 2017-06-01 01:52:56]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6d7032c3fd7b7311e54b49e267f8...