Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2909393002: Use standard-priority GL context for VrShellGl. (Closed)

Created:
3 years, 6 months ago by klausw
Modified:
3 years, 6 months ago
Reviewers:
mthiesse
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Use standard-priority GL context for VrShellGl. The high-priority GL context appears to be conflicting with GVR's internal high priority context for async reprojection, so we can't use that in other VR code. BUG=727800, 725684 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2909163003 Cr-Original-Commit-Position: refs/heads/master@{#475634} Review-Url: https://codereview.chromium.org/2909393002 Cr-Commit-Position: refs/branch-heads/3112@{#40} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/05bac91e966e8be06039390c1cb44a51f0e5957f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
klausw
Request approval for merge to 3112.
3 years, 6 months ago (2017-05-30 21:04:13 UTC) #3
mthiesse
lgtm
3 years, 6 months ago (2017-05-30 21:17:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909393002/1
3 years, 6 months ago (2017-05-30 21:17:47 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 21:18:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/05bac91e966e8be06039390c1cb4...

Powered by Google App Engine
This is Rietveld 408576698